Skip to content

gh-140601: Add ResourceWarning to iterparse when not closed #140603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 17 commits into from
Nov 13, 2025
Merged

gh-140601: Add ResourceWarning to iterparse when not closed #140603

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bf3f888
gh-140601: Add ResourceWarning to iterparse when not closed
osamakader Oct 25, 2025
e6c11de
Address review feedback from serhiy-storchaka
osamakader Oct 26, 2025
53f63b9
remove extra whitespace
osamakader Oct 26, 2025
c8ea776
remove unused import
osamakader Oct 26, 2025
fcd7ca0
Use % formatting instead of f-strings in __del__
osamakader Oct 26, 2025
0f9b509
Add assertions to verify ResourceWarning content
osamakader Oct 26, 2025
6e3b071
Remove redundant test_iterparse_resource_warning function
osamakader Oct 26, 2025
86fc36b
Remove source=self from ResourceWarning
osamakader Oct 26, 2025
329c09c
Add explicit close().
serhiy-storchaka Oct 27, 2025
dd20441
Reorganize tests.
serhiy-storchaka Oct 27, 2025
b1f67a4
Exhausted or failed iterators are auto-closed.
serhiy-storchaka Oct 27, 2025
15c0c5b
Add versionchanged directive for ResourceWarning
osamakader Oct 27, 2025
a7ef9f2
Merge branch 'main' into issue-140601-iterparse-warning
serhiy-storchaka Nov 12, 2025
766d510
Always emit a warning. Add tests for exhausted not closed iterator.
serhiy-storchaka Nov 12, 2025
53880a6
Apply suggestions from code review
serhiy-storchaka Nov 13, 2025
8a37683
Refactor tests.
serhiy-storchaka Nov 13, 2025
6c5c5e8
Merge branch 'main' into issue-140601-iterparse-warning
serhiy-storchaka Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use % formatting instead of f-strings in __del__ 
F-strings can fail during cleanup. Use % formatting like
subprocess.Popen does for safer __del__ behavior.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
  • Loading branch information
@osamakader
osamakader committed Oct 26, 2025
commit fcd7ca09a77f22aa6362bce805746c4254d0a5ec
2 changes: 1 addition & 1 deletion Lib/xml/etree/ElementTree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ def close(self):

def __del__(self, _warn=warnings.warn):
if close_source:
_warn(f"unclosed file {source!r}",
_warn("unclosed file %r" % (source,),
ResourceWarning, source=self)
source.close()

Expand Down
Loading