Skip to content

gh-140513: Fail to compile if _Py_TAIL_CALL_INTERP is set but preserve_none and musttail do not exist. #140548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 9 commits into from
Nov 1, 2025
Merged

gh-140513: Fail to compile if _Py_TAIL_CALL_INTERP is set but preserve_none and musttail do not exist. #140548

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6812a5f
fix
XChaitanyaX Oct 24, 2025
d8901b1
add space after #endif
XChaitanyaX Oct 24, 2025
95e9b6f
unnecessary `!` mark
XChaitanyaX Oct 24, 2025
d4fa2e4
commit
XChaitanyaX Oct 24, 2025
96ff7b8
commit
XChaitanyaX Oct 24, 2025
e3893ac
blurb
XChaitanyaX Oct 25, 2025
2c36f5d
fix indent
XChaitanyaX Oct 25, 2025
db8f35c
indent
XChaitanyaX Oct 27, 2025
5fb8be8
modify news entry
XChaitanyaX Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix indent 
Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
  • Loading branch information
@XChaitanyaX @chris-eibl
XChaitanyaX and chris-eibl authored Oct 25, 2025
commit 2c36f5d2b1103f3dc152cdae16c0939d56857199
14 changes: 7 additions & 7 deletions Python/ceval_macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,13 @@
#endif

#if _Py_TAIL_CALL_INTERP
# if defined(__clang__) || defined(__GNUC__)
# if !_Py__has_attribute(preserve_none) || !_Py__has_attribute(musttail)
# error "This compiler does not have support for efficient tail calling."
# endif
# elif defined(_MSC_VER) && (_MSC_VER < 1950)
# error "You need atleast VS 2026 / PlatformToolset v145 for tail calling."
# endif
# if defined(__clang__) || defined(__GNUC__)
# if !_Py__has_attribute(preserve_none) || !_Py__has_attribute(musttail)
# error "This compiler does not have support for efficient tail calling."
# endif
Comment thread
XChaitanyaX marked this conversation as resolved.
Outdated
Comment thread
XChaitanyaX marked this conversation as resolved.
Outdated
# elif defined(_MSC_VER) && (_MSC_VER < 1950)
# error "You need at least VS 2026 / PlatformToolset v145 for tail calling."
# endif

// Note: [[clang::musttail]] works for GCC 15, but not __attribute__((musttail)) at the moment.
# define Py_MUSTTAIL [[clang::musttail]]
Expand Down
Loading