Skip to content

gh-139951: Do not track immutable tuples in GC #140204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
efimov-mikhail wants to merge 20 commits into from
Closed

gh-139951: Do not track immutable tuples in GC #140204

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
fbb7342
Do not track immutable tuples in PyTuple_Pack
sergey-miryanov Sep 28, 2025
be72b3f
Extra stats
sergey-miryanov Sep 28, 2025
04f0f66
Implement for all
sergey-miryanov Sep 29, 2025
3b80c93
Merge branch 'main' into 139389-donot-track-immutable-tuples
sergey-miryanov Oct 10, 2025
ff81eb2
Count total tuples
sergey-miryanov Oct 10, 2025
f1220e4
expirements
efimov-mikhail Oct 16, 2025
8b7fcd5
some clean
efimov-mikhail Oct 16, 2025
b281fe8
Remove statistics
efimov-mikhail Oct 16, 2025
5c117a7
Update PyTuple_FromArray
efimov-mikhail Oct 16, 2025
0d7eff1
Helper function is added
efimov-mikhail Oct 16, 2025
a679b50
Update Objects/tupleobject.c
efimov-mikhail Oct 16, 2025
35dfe24
Update Objects/tupleobject.c
efimov-mikhail Oct 16, 2025
4297f8b
Review addressed
efimov-mikhail Oct 16, 2025
ddfe151
News updated
efimov-mikhail Oct 16, 2025
30dd590
expirements
efimov-mikhail Oct 16, 2025
63c0e3e
Revert GC changes
efimov-mikhail Oct 16, 2025
9ce41be
Check tuple tracking after tp_subscipt
efimov-mikhail Oct 16, 2025
77a0373
Review addressed
efimov-mikhail Oct 16, 2025
567105f
Address feedback
efimov-mikhail Oct 16, 2025
d00b16a
Merge branch 'main' into sergey-miryanov-139389-donot-track-immutable…
efimov-mikhail Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Objects/tupleobject.c 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@efimov-mikhail @vstinner
efimov-mikhail and vstinner authored Oct 16, 2025
commit 35dfe2453047742432b621f7726ff63c700ef608
2 changes: 1 addition & 1 deletion Objects/tupleobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@
}

static bool
Comment thread
efimov-mikhail marked this conversation as resolved.
tuple_need_tracking(PyTupleObject *t)
tuple_need_tracking(PyTupleObject *self)
{
Py_ssize_t n = PyTuple_GET_SIZE(t);

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

't': undeclared identifier [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

't': undeclared identifier [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

't': undeclared identifier [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

't': undeclared identifier [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

‘t’ undeclared (first use in this function)

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

‘t’ undeclared (first use in this function)

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

‘t’ undeclared (first use in this function)

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

‘t’ undeclared (first use in this function)

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

‘t’ undeclared (first use in this function)

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

‘t’ undeclared (first use in this function)

Check failure on line 162 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Cross build Linux 

‘t’ undeclared (first use in this function)
for (Py_ssize_t i = 0; i < n; i++) {
PyObject *elt = PyTuple_GET_ITEM(t, i);

Check failure on line 164 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

't': undeclared identifier [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 164 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

't': undeclared identifier [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 164 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

't': undeclared identifier [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 164 in Objects/tupleobject.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

't': undeclared identifier [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]
Comment thread
efimov-mikhail marked this conversation as resolved.
Outdated
/* Tuple with NULL elements aren't
fully constructed, we should track them. */
if (!elt ||
Comment thread
efimov-mikhail marked this conversation as resolved.
Outdated
Expand Down
Loading