Skip to content

gh-140080: Fix atexit with low memory #140103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZeroIntensity merged 14 commits into from
Oct 15, 2025
Merged

gh-140080: Fix atexit with low memory #140103

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7cdfb7c
fix: atexit_cleanup the state
yihong0618 Oct 14, 2025
da72a0b
fix: add news and tests
yihong0618 Oct 14, 2025
0f0cbef
Apply suggestions from code review
yihong0618 Oct 14, 2025
d664393
fix: move tests to atexit
yihong0618 Oct 14, 2025
b9af102
fix: empty line drop
yihong0618 Oct 14, 2025
2e2e467
fix: use assert not in instead
yihong0618 Oct 14, 2025
60d200e
fix: address comments
yihong0618 Oct 14, 2025
8d3c3a8
fix: use temp here
yihong0618 Oct 14, 2025
5e288a2
fix: ingore not requires_subprocess
yihong0618 Oct 14, 2025
42f90ab
fix: use spawn_python
yihong0618 Oct 14, 2025
294e404
Update Lib/test/test_atexit.py
yihong0618 Oct 14, 2025
1958a7a
fix: apply comments
yihong0618 Oct 14, 2025
7ab0231
fix: indentation level for test code in test
yihong0618 Oct 14, 2025
00b5a8c
fix: use test helper function
yihong0618 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use assert not in instead 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
  • Loading branch information
@yihong0618
yihong0618 committed Oct 14, 2025
commit 2e2e467ed240916b128c931fe49fbdf6e0fc44d8
4 changes: 3 additions & 1 deletion Lib/test/test_atexit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ def test_atexit_with_low_memory(self):
import _testcapi

def callback():
print("hello")
pass
Comment thread
yihong0618 marked this conversation as resolved.
Outdated

atexit.register(callback)
Expand All @@ -211,9 +212,10 @@ def callback():
with script_helper.spawn_python('-c', user_input,
stderr=subprocess.PIPE) as p:
p.wait()
p.stdout.read()
output = p.stdout.read()
Comment thread
yihong0618 marked this conversation as resolved.
Outdated

self.assertIn(p.returncode, (0, 1))
self.assertNotIn(b"hello", output)


if __name__ == "__main__":
Expand Down
Loading