Skip to content

gh-136655: ensure cancelled futures are notified on process pool shutdown #140021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duaneg wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-136655: ensure cancelled futures are notified on process pool shutdown #140021

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc3a3fe
gh-136655: ensure cancelled futures are notified on process pool shut…
duaneg Jul 15, 2025
dc48587
Use default timeout for barrier in test
duaneg Oct 13, 2025
f10dbb9
Silence fork-in-thread warnings, incidentally fixing a mysterious and…
duaneg Oct 15, 2025
32cfb29
Address reviewer feedback
duaneg Oct 17, 2025
9827662
Skip instead of failing if assumptions are invalid
duaneg Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Skip instead of failing if assumptions are invalid
  • Loading branch information
@duaneg
duaneg committed Oct 17, 2025
commit 98276628f034a4e3116e8df44685c1464278a09b
3 changes: 2 additions & 1 deletion Lib/test/test_concurrent_futures/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,8 @@ def test_swallows_falsey_exceptions(self):

@warnings_helper.ignore_fork_in_thread_deprecation_warnings()
def test_shutdown_notifies_cancelled_futures(self):
self.assertGreater(self.worker_count, 1)
if self.worker_count < 2:
self.skipTest("test requires more than one worker")

# TODO: remove when gh-109934 is fixed
if self.executor_type is futures.ThreadPoolExecutor:
Expand Down
Loading