Skip to content

bpo-29453: Remove reference to undefined dictionary ordering in Tutorial #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mariatta merged 2 commits into from
Feb 21, 2017
Merged

bpo-29453: Remove reference to undefined dictionary ordering in Tutorial #140

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b7cd22
bpo-29453: Remove reference to undefined dictionary ordering in Tutorial
DimitrisJim Feb 16, 2017
b565db5
Add sentence mentioning guaranteed output order of kwargs
DimitrisJim Feb 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-29453: Remove reference to undefined dictionary ordering in Tutorial 
As of Python 3.6 **kwargs are ordered, thus, remove the paragraph stating that
ordering is undefined and change snippet to remove the unecessary sorted call.
  • Loading branch information
@DimitrisJim
DimitrisJim committed Feb 16, 2017
commit 2b7cd229c85c656c4cd2e973325167d8e2fceedd
8 changes: 2 additions & 6 deletions Doc/tutorial/controlflow.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,8 +492,7 @@ function like this::
for arg in arguments:
print(arg)
print("-" * 40)
keys = sorted(keywords.keys())
for kw in keys:
for kw in keywords:
print(kw, ":", keywords[kw])

It could be called like this::
Expand All @@ -513,13 +512,10 @@ and of course it would print:
It's very runny, sir.
It's really very, VERY runny, sir.
----------------------------------------
client : John Cleese
shopkeeper : Michael Palin
client : John Cleese
sketch : Cheese Shop Sketch

Note that the list of keyword argument names is created by sorting the result
of the keywords dictionary's ``keys()`` method before printing its contents;
if this is not done, the order in which the arguments are printed is undefined.

.. _tut-arbitraryargs:

Expand Down