Skip to content

gh-139899: Introduce MetaPathFinder.discover and PathEntryFinder.discover #139900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FFY00 merged 15 commits into from
Feb 19, 2026
Merged

gh-139899: Introduce MetaPathFinder.discover and PathEntryFinder.discover #139900

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8099249
gh-139899: Introduce MetaPathFinder.discover and PathEntryFinder.disc…
FFY00 Oct 10, 2025
6816705
Fix doc reference
FFY00 Dec 10, 2025
31d1a8f
Remove specific doc references
FFY00 Dec 10, 2025
051cd1e
Fix docstrings
FFY00 Dec 10, 2025
c343d32
Revert "Remove specific doc references"
FFY00 Dec 10, 2025
a324d96
Fix news references
FFY00 Dec 10, 2025
dc6faa2
Add docs warning
FFY00 Jan 20, 2026
3be757f
Raise ValueError on invalid parent
FFY00 Jan 20, 2026
0da477f
Dedupe __path__ in PathFinder.discover
FFY00 Jan 20, 2026
282bef7
Use context manager and add error handling to os.scandir
FFY00 Jan 20, 2026
469dc2a
Raise ValueError on invalid parent
FFY00 Jan 20, 2026
c09a12e
Dedupe when package exists with multiple suffixes
FFY00 Jan 20, 2026
41cd071
Apply suggestions from code review
FFY00 Jan 20, 2026
5488e93
Add tests
FFY00 Jan 22, 2026
fc1de5f
Merge branch 'main' into gh-139899
brettcannon Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Raise ValueError on invalid parent 
Signed-off-by: Filipe Laíns <lains@riseup.net>
  • Loading branch information
@FFY00
FFY00 committed Jan 20, 2026
commit 3be757f44533809df1d770fc41a0728f42438711
2 changes: 2 additions & 0 deletions Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,6 +1327,8 @@ def find_spec(cls, fullname, path=None,>
def discover(cls, parent=None):
if parent is None:
path = sys.path
elif parent.submodule_search_locations is None:
raise ValueError(f'{parent} is not a package module')
else:
path = parent.submodule_search_locations

@gpshead gpshead Dec 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be None when parent is a non-package module? make a nicer error message or should this situation use sys.path?

@FFY00 FFY00 Dec 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can it be a non-package module if it has a child? It could be a namespace package, but that's still a package, and parent.submodule_search_locations should be an iterable objects when the spec is fully initialized, which it should always be at this point.

Unless I am missing something? Do we support package-like module extensions?

@ncoghlan ncoghlan Jan 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @gpshead is referring to the error case where parent.submodule_search_locations is None because the caller supplied a "parent" spec from a non-package module. Instead of the default "'NoneType' object is not iterable" message from the failed iteration attempt, we should raise something more specific.


Expand Down