Skip to content

gh-139888: Add PyTupleWriter C API #139891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 18 commits into from
Closed

gh-139888: Add PyTupleWriter C API #139891

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
542c4c4
gh-139888: Add PyTupleWriter C API
vstinner Oct 7, 2025
86d529b
Add AddSteal() and AddArray() functions
vstinner Oct 10, 2025
afbe7bf
Fix refleak in PySequence_Tuple()
vstinner Oct 10, 2025
7787017
Hard deprecate _PyTuple_Resize()
vstinner Oct 10, 2025
a9a6aab
Optimize _PyTupleWriter_SetSize()
vstinner Oct 10, 2025
8719f11
Add test on PyTupleWriter_Create(-2)
vstinner Oct 10, 2025
9e42598
Fix compiler warning
vstinner Oct 10, 2025
eef02ff
_PyTupleWriter_Create() doesn't need to copy small_tuple
vstinner Oct 10, 2025
5cf5915
Fix assertion
vstinner Oct 10, 2025
871ee85
Fix leak in PyTupleWriter_Discard()
vstinner Oct 10, 2025
8e7025f
Accept NULL in Add() and AddSteal()
vstinner Oct 11, 2025
d27df40
Use PyTupleWriter in multiple functions
vstinner Oct 11, 2025
537989d
Update What's New
vstinner Oct 11, 2025
01ae040
Convert genericalias _Py_make_parameters() to writer
vstinner Oct 12, 2025
05758b7
Optimize allocation
vstinner Oct 12, 2025
b124698
Overallocate by 50%
vstinner Oct 12, 2025
bf39d69
Revert _tkinter._flatten()
vstinner Oct 12, 2025
1e28698
Fix comment
vstinner Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compiler warning
  • Loading branch information
@vstinner
vstinner committed Oct 10, 2025
commit 9e42598538d42c1556c65d263666a532ec3ecee0
2 changes: 1 addition & 1 deletion Objects/tupleobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,7 +1294,7 @@ PyTupleWriter_Create(Py_ssize_t size)
writer->size = 0;
writer->allocated = Py_ARRAY_LENGTH(writer->small_tuple);

if (size > writer->allocated) {
if ((size_t)size > writer->allocated) {
if (_PyTupleWriter_SetSize(writer, size, 0) < 0) {
PyTupleWriter_Discard(writer);
return NULL;
Expand Down
Loading