Skip to content

gh-90949: Recommend hasattr with Expat security methods #139800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 9 commits into from
Oct 14, 2025
Merged

gh-90949: Recommend hasattr with Expat security methods #139800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
834a7e0
Doc/library/pyexpat.rst: Recommend "hasattr" with Expat security methods
hartwork Oct 8, 2025
828f786
Doc/library/pyexpat.rst: Use ".. note::" with SetReparseDeferralEnabled
hartwork Oct 8, 2025
c932512
Doc/library/xml.etree.elementtree.rst: Use ".. note::" for backport n…
hartwork Oct 8, 2025
32d51e3
Doc/library/xml.etree.elementtree.rst: Add missing indent by 3
hartwork Oct 8, 2025
67b5221
Add an exclemation mark to suppress distracting links
hartwork Oct 9, 2025
5014423
Demo more quiet version without ".. note::"
hartwork Oct 9, 2025
a4f79ad
Revert accidental addition of blank line
hartwork Oct 13, 2025
d5ecaa2
Drop "Note that " at the start of the sentence
hartwork Oct 13, 2025
6e397c4
Resolve double self reference
hartwork Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add an exclemation mark to suppress distracting links 
Related:
https://devguide.python.org/documentation/style-guide/#links

Idea by @picnixz
  • Loading branch information
@hartwork
hartwork committed Oct 9, 2025
commit 67b52216ec429f62735266603f4f5d7e8833feea
20 changes: 10 additions & 10 deletions Doc/library/pyexpat.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,10 @@ XMLParser Objects

.. note::

:meth:`SetReparseDeferralEnabled`
:meth:`!SetReparseDeferralEnabled`
has been backported to some prior releases of CPython as a security fix.
Check for availability of
:meth:`SetReparseDeferralEnabled`
:meth:`!SetReparseDeferralEnabled`
using :func:`hasattr` if used in code running across a variety of Python
versions.

Expand Down Expand Up @@ -268,10 +268,10 @@ against some common XML vulnerabilities.

.. note::

:meth:`SetBillionLaughsAttackProtectionActivationThreshold`
:meth:`!SetBillionLaughsAttackProtectionActivationThreshold`
has been backported to some prior releases of CPython as a security fix.
Check for availability of
:meth:`SetBillionLaughsAttackProtectionActivationThreshold`
:meth:`!SetBillionLaughsAttackProtectionActivationThreshold`
using :func:`hasattr` if used in code running across a variety of Python
versions.

Comment thread
hartwork marked this conversation as resolved.
Outdated
Expand Down Expand Up @@ -309,10 +309,10 @@ against some common XML vulnerabilities.

.. note::

:meth:`SetBillionLaughsAttackProtectionMaximumAmplification`
:meth:`!SetBillionLaughsAttackProtectionMaximumAmplification`
has been backported to some prior releases of CPython as a security fix.
Check for availability of
:meth:`SetBillionLaughsAttackProtectionMaximumAmplification`
:meth:`!SetBillionLaughsAttackProtectionMaximumAmplification`
using :func:`hasattr` if used in code running across a variety of Python
versions.

Expand All @@ -333,10 +333,10 @@ against some common XML vulnerabilities.

.. note::

:meth:`SetAllocTrackerActivationThreshold`
:meth:`!SetAllocTrackerActivationThreshold`
has been backported to some prior releases of CPython as a security fix.
Check for availability of
:meth:`SetAllocTrackerActivationThreshold`
:meth:`!SetAllocTrackerActivationThreshold`
using :func:`hasattr` if used in code running across a variety of Python
versions.

Expand Down Expand Up @@ -373,10 +373,10 @@ against some common XML vulnerabilities.

.. note::

:meth:`SetAllocTrackerMaximumAmplification`
:meth:`!SetAllocTrackerMaximumAmplification`
has been backported to some prior releases of CPython as a security fix.
Check for availability of
:meth:`SetAllocTrackerMaximumAmplification`
:meth:`!SetAllocTrackerMaximumAmplification`
using :func:`hasattr` if used in code running across a variety of Python
versions.

Expand Down
8 changes: 4 additions & 4 deletions Doc/library/xml.etree.elementtree.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,10 +1400,10 @@ XMLParser Objects

.. note::
Comment thread
StanFromIreland marked this conversation as resolved.
Outdated

:meth:`flush`
:meth:`!flush`
has been backported to some prior releases of CPython as a security
fix. Check for availability of
:meth:`flush`
:meth:`!flush`
using :func:`hasattr` if used in code running across a variety of
Python versions.

Expand Down Expand Up @@ -1482,10 +1482,10 @@ XMLPullParser Objects

.. note::
Comment thread
StanFromIreland marked this conversation as resolved.
Outdated

:meth:`flush`
:meth:`!flush`
has been backported to some prior releases of CPython as a security
fix. Check for availability of
:meth:`flush`
:meth:`!flush`
using :func:`hasattr` if used in code running across a variety of
Python versions.

Expand Down
Loading