Repository navigation
gh-139458: Fix Interpreter Methods For the Main Interpreter - #139521
Open
ericsnowcurrently wants to merge 5 commits into
Open
ericsnowcurrently wants to merge 5 commits into
ericsnowcurrently wants to merge 5 commits into
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
Bot
removed
the
stale
|
This PR is stale because it has been open for 90 days with no activity. |
github-actions
Bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some methods of
concurrent.interpreters.Interpreterwere not working for the object representing the main interpreter (ID 0). The relevant code was identifying an interpreter not created by theinterpretersmodule as "unrecognized". However, the error message was a bit confusing since it did not distinguish between "not supported" and "doesn't exist".This is addressed here for the main interpreter by special-casing it. The relevant methods now fail with a clearer message along the lines of "already running main". For other interpreters (e.g. created via C-API), the message is now clearer as well.
📚 Documentation preview 📚: https://cpython-previews--139521.org.readthedocs.build/