Skip to content

gh-67795: Improve precision of non-float timestamp and timeout arguments #139273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-storchaka wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-67795: Improve precision of non-float timestamp and timeout arguments #139273

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90f8bf2
gh-67795: Improve precision of non-float timestamp and timeout arguments
serhiy-storchaka Sep 23, 2025
68433af
Apply suggestions from code review
serhiy-storchaka Oct 3, 2025
937be4c
Add more comments.
serhiy-storchaka Oct 3, 2025
6be1856
Merge branch 'main' into timestamp-timeout-as-integer-ratio
serhiy-storchaka May 4, 2026
a93adbd
Replace _PyTime_FromLong with PyLong_AsInt64.
serhiy-storchaka May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@serhiy-storchaka @vstinner
serhiy-storchaka and vstinner authored Oct 3, 2025
commit 68433af3a29b75d6ecef5c1cf1ce838fe6250f14
6 changes: 4 additions & 2 deletions Python/pytime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,18 +442,20 @@ checked_divmod(PyObject *a, PyObject *b)
static PyObject *
divide_and_round(PyObject *numerator, PyObject *denominator, _PyTime_round_t round)
{
PyObject *divmod, *result;
if (round == _PyTime_ROUND_UP) {
int isneg = PyObject_RichCompareBool(numerator, _PyLong_GetZero(), Py_LT);
if (isneg < 0) {
return NULL;
}
round = isneg ? _PyTime_ROUND_FLOOR : _PyTime_ROUND_CEILING;
}

if (round == _PyTime_ROUND_FLOOR) {
return PyNumber_FloorDivide(numerator, denominator);
}
else if (round == _PyTime_ROUND_CEILING) {

PyObject *divmod, *result;
if (round == _PyTime_ROUND_CEILING) {
divmod = checked_divmod(numerator, denominator);
if (divmod == NULL) {
return NULL;
Expand Down