Skip to content

gh-126016: Remove bad assertion in PyThreadState_Clear #139158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZeroIntensity merged 4 commits into from
Sep 19, 2025
Merged

gh-126016: Remove bad assertion in PyThreadState_Clear #139158

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
926e45d
Remove assertion in PyThreadState_Clear().
ZeroIntensity Sep 19, 2025
29b0dc9
Add a test case.
ZeroIntensity Sep 19, 2025
3246646
Fix formatting.
ZeroIntensity Sep 19, 2025
18bff5c
Add blurb.
ZeroIntensity Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test case.
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Sep 19, 2025
commit 29b0dc920ad425a9084ffda15e94ef574b171e34
29 changes: 28 additions & 1 deletion Lib/test/test_interpreters/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import contextlib
import os
import pickle
import signal
import sys
from textwrap import dedent
import threading
Expand All @@ -11,7 +12,7 @@
from test.support import os_helper
from test.support import script_helper
from test.support import import_helper
from test.support.script_helper import assert_python_ok
from test.support.script_helper import assert_python_ok, spawn_python
# Raise SkipTest if subinterpreters not supported.
_interpreters = import_helper.import_module('_interpreters')
from concurrent import interpreters
Expand Down Expand Up @@ -434,6 +435,32 @@ def test_cleanup_in_repl(self):
self.assertIn(b"remaining subinterpreters", stdout)
self.assertNotIn(b"Traceback", stdout)

@support.requires_subprocess()
@unittest.skipIf(os.name == 'nt', "signals don't work well on windows")
def test_keyboard_interrupt_in_thread_running_interp(self):
import subprocess
source = f"""if True:
from concurrent import interpreters
from threading import Thread

def test():
import time
print('a', flush=True, end='')
time.sleep(10)

interp = interpreters.create()
interp.call_in_thread(test)
"""

with spawn_python("-c", source, stderr=subprocess.PIPE) as proc:
self.assertEqual(proc.stdout.read(1), b'a')
proc.send_signal(signal.SIGINT)
proc.stderr.flush()
error = proc.stderr.read()
self.assertIn(b"KeyboardInterrupt", error)
retcode = proc.wait()
self.assertEqual(retcode, 0)



class TestInterpreterIsRunning(TestBase):
Expand Down