Skip to content

gh-136003: Skip non-daemon threads when exceptions occur during finalization #139129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZeroIntensity merged 4 commits into from
Sep 18, 2025
Merged

gh-136003: Skip non-daemon threads when exceptions occur during finalization #139129

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f9e675
Ignore non-daemon threads when KeyboardInterrupt is sent during final…
ZeroIntensity Sep 18, 2025
2f5073c
Add a test case.
ZeroIntensity Sep 18, 2025
34b8b7e
Remove flaky part of test.
ZeroIntensity Sep 18, 2025
3455f05
SKip the test on Windows.
ZeroIntensity Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
SKip the test on Windows.
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Sep 18, 2025
commit 3455f0535089a8f7c5b06132e1cedcaa90172748
1 change: 1 addition & 0 deletions Lib/test/test_threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,6 +2084,7 @@ def test_dummy_thread_on_interpreter_shutdown(self):
self.assertEqual(err, b"")

@requires_subprocess()
@unittest.skipIf(os.name == 'nt', "signals don't work well on windows")
def test_keyboard_interrupt_during_threading_shutdown(self):
import subprocess
source = f"""
Expand Down
Loading