Skip to content

gh-138709: Implement CPU time profiling in profiling.sample #138710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 16 commits into from
Sep 19, 2025
Merged

gh-138709: Implement CPU time profiling in profiling.sample #138710

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fb8983c
gh-138709: Implement CPU time profiling in profiling.sample
pablogsal Sep 9, 2025
8859bf8
Implement GIL mode and filtering
pablogsal Sep 15, 2025
ad43334
Implement GIL mode and filtering
pablogsal Sep 15, 2025
1767b39
More tests
pablogsal Sep 15, 2025
79066ec
Merge remote-tracking branch 'upstream/main' into cputime
pablogsal Sep 15, 2025
9685f2d
fixup! Merge remote-tracking branch 'upstream/main' into cputime
pablogsal Sep 15, 2025
cb6a43d
fixup! fixup! Merge remote-tracking branch 'upstream/main' into cputime
pablogsal Sep 15, 2025
f6ac8cc
fixup! fixup! fixup! Merge remote-tracking branch 'upstream/main' int…
pablogsal Sep 15, 2025
457ca99
More tests
pablogsal Sep 15, 2025
84c47e4
More tests
pablogsal Sep 15, 2025
0cc0b5a
More tests
pablogsal Sep 15, 2025
7e2d94f
More tests
pablogsal Sep 15, 2025
a95bdaf
Fix Programs/test_frozenmain.h
pablogsal Sep 15, 2025
1766992
Fix test
pablogsal Sep 16, 2025
5fae57e
fixup! Fix test
pablogsal Sep 17, 2025
2328c84
Update Modules/_remote_debugging_module.c
pablogsal Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement GIL mode and filtering
  • Loading branch information
@pablogsal
pablogsal committed Sep 15, 2025
commit ad433347113b1411075c335f510857b357fe9825
18 changes: 9 additions & 9 deletions Lib/test/test_profiling/test_sampling_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1996,7 +1996,7 @@ def test_cli_module_argument_parsing(self):
show_summary=True,
output_format="pstats",
realtime_stats=False,
skip_idle=False
mode=0
)

@unittest.skipIf(is_emscripten, "socket.SO_REUSEADDR does not exist")
Expand Down Expand Up @@ -2024,7 +2024,7 @@ def test_cli_module_with_arguments(self):
show_summary=True,
output_format="pstats",
realtime_stats=False,
skip_idle=False
mode=0
)

@unittest.skipIf(is_emscripten, "socket.SO_REUSEADDR does not exist")
Expand Down Expand Up @@ -2052,7 +2052,7 @@ def test_cli_script_argument_parsing(self):
show_summary=True,
output_format="pstats",
realtime_stats=False,
skip_idle=False
mode=0
)

@unittest.skipIf(is_emscripten, "socket.SO_REUSEADDR does not exist")
Expand Down Expand Up @@ -2152,7 +2152,7 @@ def test_cli_module_with_profiler_options(self):
show_summary=True,
output_format="pstats",
realtime_stats=False,
skip_idle=False
mode=0
)

@unittest.skipIf(is_emscripten, "socket.SO_REUSEADDR does not exist")
Expand Down Expand Up @@ -2186,7 +2186,7 @@ def test_cli_script_with_profiler_options(self):
show_summary=True,
output_format="collapsed",
realtime_stats=False,
skip_idle=False
mode=0
)

def test_cli_empty_module_name(self):
Expand Down Expand Up @@ -2398,7 +2398,7 @@ def test_argument_parsing_basic(self):
show_summary=True,
output_format="pstats",
realtime_stats=False,
skip_idle=False
mode=0
)

def test_sort_options(self):
Expand Down Expand Up @@ -2526,7 +2526,7 @@ def main():
proc.pid,
duration_sec=0.5,
sample_interval_usec=5000,
skip_idle=True, # CPU mode
mode=1, # CPU mode
show_summary=False,
all_threads=True,
)
Expand All @@ -2535,7 +2535,7 @@ def main():

cpu_mode_output = captured_output.getvalue()

# Test wall-clock mode (skip_idle=False) - should capture both functions
# Test wall-clock mode (mode=0) - should capture both functions
with (
io.StringIO() as captured_output,
mock.patch("sys.stdout", captured_output),
Expand All @@ -2545,7 +2545,7 @@ def main():
proc.pid,
duration_sec=0.5,
sample_interval_usec=5000,
skip_idle=False, # Wall-clock mode
mode=0, # Wall-clock mode
show_summary=False,
all_threads=True,
)
Expand Down