Skip to content

gh-138535: Optimize fill_time for typical timestamps #138537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 7 commits into from
Sep 9, 2025
Merged

gh-138535: Optimize fill_time for typical timestamps #138537

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a92719d
Optimize fill_time for typical timestamps
jbosboom Sep 5, 2025
6f05f25
Address review comments
jbosboom Sep 5, 2025
bbab367
assert(!PyErr_Occurred()) only on success
jbosboom Sep 6, 2025
1a9183c
Fix typo in fast path upper bound
jbosboom Sep 7, 2025
2c74007
Add tests for boundaries of fast path
jbosboom Sep 7, 2025
30d790f
Add blurb
jbosboom Sep 7, 2025
be7d76f
Apply suggestions from code review
jbosboom Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assert(!PyErr_Occurred()) only on success
  • Loading branch information
@jbosboom
jbosboom committed Sep 6, 2025
commit bbab367c2734e1238618008b994bd7881f8ddeeb
3 changes: 2 additions & 1 deletion Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2616,6 +2616,7 @@ fill_time(PyObject *module, PyObject *v, int s_index, int f_index, int ns_index,
return -1;
}
PyStructSequence_SET_ITEM(v, ns_index, ns_total);
assert(!PyErr_Occurred());
res = 0;
}
else {
Expand All @@ -2637,6 +2638,7 @@ fill_time(PyObject *module, PyObject *v, int s_index, int f_index, int ns_index,
goto exit;
}
PyStructSequence_SET_ITEM(v, ns_index, ns_total);
assert(!PyErr_Occurred());
res = 0;

exit:
Expand All @@ -2646,7 +2648,6 @@ fill_time(PyObject *module, PyObject *v, int s_index, int f_index, int ns_index,
}
}

assert(!PyErr_Occurred());
return res;
#undef S_TO_NS
}
Expand Down