Skip to content

gh-121190: A better error message from importlib.resources.files() when module spec is None #138531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whitphx wants to merge 9 commits into from
Closed

gh-121190: A better error message from importlib.resources.files() when module spec is None #138531

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
078c801
Raise an exception with a better message from importlib.resources.fil…
whitphx Sep 5, 2025
c79a7cc
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 5, 2025
5ed2652
Fix Blurb
whitphx Sep 5, 2025
847d8df
Remove type annotations
whitphx Sep 6, 2025
e25491e
Modify the error message
whitphx Sep 7, 2025
06b8233
Merge branch 'main' into gh-121190
whitphx Sep 10, 2025
7dc7e46
Revert a change removing the default adapter argument on SpecLoaderAd…
whitphx Sep 19, 2025
9e98cfc
Apply suggestion from @danielhollas
whitphx Oct 22, 2025
d3ec82a
fix the error message
whitphx Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Modify the error message
  • Loading branch information
@whitphx
whitphx committed Sep 7, 2025
commit e25491eb5e6286d0cf0ba143c4b08ecb317e0720
5 changes: 4 additions & 1 deletion Lib/importlib/resources/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ def from_package(package: types.ModuleType):
from ._adapters import wrap_spec

if package.__spec__ is None:
raise TypeError(f"Can't access resources on a module with no spec: {package}")
raise TypeError(
f"Cannot access resources because the code used to populate '{package.__name__}' "
"does not correspond directly with an importable module."
Comment thread
whitphx marked this conversation as resolved.
Outdated
)

spec = wrap_spec(package.__spec__)
reader = spec.loader.get_resource_reader(spec.name)
Expand Down
Loading