Skip to content

gh-138489: Install build-details.json on Windows #138490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AA-Turner wants to merge 13 commits into from
Closed

gh-138489: Install build-details.json on Windows #138490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1901e80
Install ``build-details.json`` on Windows
AA-Turner Sep 3, 2025
dbe1cbd
Update python.vcxproj
AA-Turner Sep 4, 2025
c80344c
Fix ```--relative-paths``
AA-Turner Sep 4, 2025
ee39ea7
Specify encoding when writing file
AA-Turner Sep 4, 2025
f5f0548
Add test for ``--relative-paths``
AA-Turner Sep 4, 2025
fdba9f0
Lint (splitroot requires 3.12)
AA-Turner Sep 4, 2025
6a2cc71
Revert relative-path changes.
AA-Turner Sep 4, 2025
bd9bf46
Merge branch 'main' into pep739-windows
AA-Turner Sep 15, 2025
8d58be4
Regenerate build-details.json via PC\layout\
AA-Turner Sep 16, 2025
a927601
Fix the generated data for Windows
AA-Turner Sep 16, 2025
d743693
Fail gracefully
AA-Turner Sep 16, 2025
d18f70e
bin the type statements
AA-Turner Sep 16, 2025
57f3b26
yet more linting banality
AA-Turner Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the generated data for Windows
  • Loading branch information
@AA-Turner
AA-Turner committed Sep 16, 2025
commit a9276015ad6c41a6c0024a6dfe3e8334aa4b3530
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ gmon.out
.pytest_cache/
.ruff_cache/
.DS_Store
__install__.json
build-details.json

*.exe

Expand Down
23 changes: 17 additions & 6 deletions Tools/build/generate_build_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,15 @@ def generate_data(

data['base_prefix'] = sysconfig.get_config_var('installed_base')
#data['base_interpreter'] = sys._base_executable
data['base_interpreter'] = os.path.join(
sysconfig.get_path('scripts'),
'python' + sysconfig.get_config_var('VERSION'),
)
if os.name == 'nt':
data['base_interpreter'] = os.path.join(
data['base_prefix'], os.path.basename(sys._base_executable)
)
else:
data['base_interpreter'] = os.path.join(
sysconfig.get_path('scripts'),
'python' + sysconfig.get_config_var('VERSION'),
)
data['platform'] = sysconfig.get_platform()

data['language']['version'] = sysconfig.get_python_version()
Expand All @@ -94,13 +99,19 @@ def generate_data(
#data['suffixes']['debug_bytecode'] = importlib.machinery.DEBUG_BYTECODE_SUFFIXES
data['suffixes']['extensions'] = importlib.machinery.EXTENSION_SUFFIXES

LIBDIR = sysconfig.get_config_var('LIBDIR')
if os.name == 'nt':
LIBDIR = data['base_prefix']
else:
LIBDIR = sysconfig.get_config_var('LIBDIR')
LDLIBRARY = sysconfig.get_config_var('LDLIBRARY')
LIBRARY = sysconfig.get_config_var('LIBRARY')
PY3LIBRARY = sysconfig.get_config_var('PY3LIBRARY')
LIBPYTHON = sysconfig.get_config_var('LIBPYTHON')
LIBPC = sysconfig.get_config_var('LIBPC')
INCLUDEPY = sysconfig.get_config_var('INCLUDEPY')
if os.name == 'nt':
INCLUDEPY = os.path.join(data['base_prefix'], 'include')
else:
INCLUDEPY = sysconfig.get_config_var('INCLUDEPY')

if os.name == 'posix':
# On POSIX, LIBRARY is always the static library, while LDLIBRARY is the
Expand Down