Skip to content

GH-137573: mark _PyOptimizer_Optimize as no inline #137731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 3 commits into from
Aug 14, 2025
Merged

GH-137573: mark _PyOptimizer_Optimize as no inline #137731

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d093c0
mark _PyOptimizer_Optimize as no inline
inventshah Aug 13, 2025
318c4fd
Update Misc/NEWS.d/next/C_API/2025-08-13-13-41-04.gh-issue-137573.r6u…
inventshah Aug 13, 2025
6831ee7
Add a comment for the future
encukou Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add a comment for the future
  • Loading branch information
@encukou
encukou authored Aug 14, 2025
commit 6831ee72a3edc3b7d273173ee1026a5e1d94e634
1 change: 1 addition & 0 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ uop_optimize(_PyInterpreterFrame *frame, _Py_CODEUNIT *instr,
/* Returns 1 if optimized, 0 if not optimized, and -1 for an error.
* If optimized, *executor_ptr contains a new reference to the executor
*/
// gh-137573: inlining this function causes stack overflows
Py_NO_INLINE int
Comment thread
encukou marked this conversation as resolved.
_PyOptimizer_Optimize(
_PyInterpreterFrame *frame, _Py_CODEUNIT *start,
Expand Down