Skip to content

GH-137573: Check C stack depth before stack allocating JIT optimizer struct #137676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markshannon wants to merge 4 commits into from
Closed

GH-137573: Check C stack depth before stack allocating JIT optimizer struct #137676

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2c2a78
Check C stack depth before stack allocating JIT optimizer struct
markshannon Aug 12, 2025
ef27395
Add news
markshannon Aug 12, 2025
0a889df
Update Lib/test/test_call.py
markshannon Aug 13, 2025
be99bd4
Account for trace buffer as well
markshannon Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Account for trace buffer as well
  • Loading branch information
@markshannon
markshannon committed Aug 13, 2025
commit be99bd445018d5d6ef08d240caac9489200ea654
6 changes: 6 additions & 0 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ _PyOptimizer_Optimize(
_PyInterpreterFrame *frame, _Py_CODEUNIT *start,
_PyExecutorObject **executor_ptr, int chain_depth)
{
/* Make sure we have enough C stack space for the buffer */
int margin = 1 + sizeof(_PyUOpInstruction) * UOP_MAX_TRACE_LENGTH / _PyOS_STACK_MARGIN_BYTES;
if (_Py_ReachedRecursionLimitWithMargin(_PyThreadState_GET(), margin)) {
return 0;
}

_PyStackRef *stack_pointer = frame->stackpointer;
assert(_PyInterpreterState_GET()->jit);
// The first executor in a chain and the MAX_CHAIN_DEPTH'th executor *must*
Expand Down