Skip to content

bpo-35621: Fix tests when SafeChildWatcher is expected instead of ThreadedChildWatcher #13754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 3 commits into from
Jun 2, 2019
Merged

bpo-35621: Fix tests when SafeChildWatcher is expected instead of ThreadedChildWatcher #13754

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aae056
Fix tests when SafeChildWatcher is expected instead of ThreadedChildW…
asvetlov Jun 2, 2019
7216c6f
Set policy in the right place
asvetlov Jun 2, 2019
e930712
Fix spaces
asvetlov Jun 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/test_asyncio/test_unix_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1824,8 +1824,6 @@ def test_get_child_watcher_after_set(self):
def test_get_child_watcher_thread(self):

def f():
policy.set_event_loop(policy.new_event_loop())

@pablogsal pablogsal Jun 2, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:

def f():
    policy.set_event_loop(policy.new_event_loop())
    policy.set_child_watcher(asyncio.SafeChildWatcher())

@asvetlov asvetlov Jun 2, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to keep policy.set_event_loop() in a thread but setup the watcher in the main thread (it is crucial for the test).


self.assertIsInstance(policy.get_event_loop(),
asyncio.AbstractEventLoop)
watcher = policy.get_child_watcher()
Expand All @@ -1836,6 +1834,8 @@ def f():
policy.get_event_loop().close()

policy = self.create_policy()
policy.set_child_watcher(asyncio.SafeChildWatcher())
policy.set_event_loop(policy.new_event_loop())

th = threading.Thread(target=f)
th.start()
Expand Down