Skip to content

gh-136306: fix test_ssl.ContextTests.test_set_groups on FIPS builds #137405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 2 commits into from
Aug 5, 2025
Merged

gh-136306: fix test_ssl.ContextTests.test_set_groups on FIPS builds #137405

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
220f043
fix `test_ssl.ContextTests.test_set_groups` on FIPS builds
picnixz Aug 5, 2025
c036867
take 2
picnixz Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
take 2
  • Loading branch information
@picnixz
picnixz committed Aug 5, 2025
commit c0368678e510c0fea45f3fbbd45c20b66bb189ab
13 changes: 9 additions & 4 deletions Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
HOST = socket_helper.HOST
IS_OPENSSL_3_0_0 = ssl.OPENSSL_VERSION_INFO >= (3, 0, 0)
CAN_GET_SELECTED_OPENSSL_GROUP = ssl.OPENSSL_VERSION_INFO >= (3, 2)
CAN_IGNORE_UNKNOWN_OPENSSL_GROUPS = ssl.OPENSSL_VERSION_INFO >= (3, 3)
CAN_GET_AVAILABLE_OPENSSL_GROUPS = ssl.OPENSSL_VERSION_INFO >= (3, 5)
PY_SSL_DEFAULT_CIPHERS = sysconfig.get_config_var('PY_SSL_DEFAULT_CIPHERS')

Expand Down Expand Up @@ -964,10 +965,14 @@ def test_get_ciphers(self):

def test_set_groups(self):
ctx = ssl.create_default_context()
# Use '?' for X25519 as the latter is not allowed if
# OpenSSL has been built with FIPS module support.
self.assertIsNone(ctx.set_groups('P-256:?X25519'))
self.assertRaises(ssl.SSLError, ctx.set_groups, 'P-256:xxx')
# We use P-256 and P-384 (FIPS 186-4) that are alloed by OpenSSL
# even if FIPS module is enabled. Ignoring unknown groups is only
# supported since OpenSSL 3.3.
self.assertIsNone(ctx.set_groups('P-256:P-384'))

self.assertRaises(ssl.SSLError, ctx.set_groups, 'P-256:foo')
if CAN_IGNORE_UNKNOWN_OPENSSL_GROUPS:
self.assertIsNone(ctx.set_groups('P-256:?foo'))

@unittest.skipUnless(CAN_GET_AVAILABLE_OPENSSL_GROUPS,
"OpenSSL version doesn't support getting groups")
Expand Down