Skip to content

gh-132413: Clear weakref to _datetime after modules are finalized #136152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neonene wants to merge 13 commits into from
Closed

gh-132413: Clear weakref to _datetime after modules are finalized #136152

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ff10134
NEWS
neonene Jun 30, 2025
4f83cb0
Add test
neonene Jun 30, 2025
4e83b5b
Avoid weakref being cleared by GC
neonene Jun 30, 2025
c4b1c62
Do not hold module in tuple
neonene Jul 1, 2025
4b1b45c
GC-untrack/track
neonene Jul 1, 2025
c5a2f41
Merge branch 'main' into wr-132413
neonene Jul 1, 2025
e33f704
Sort weaklist
neonene Jul 1, 2025
263bdb2
Add non-NULL check
neonene Jul 1, 2025
fdfadf0
Simply do not GC-untrack/track
neonene Jul 1, 2025
26c6425
Add a missing NULL check
neonene Jul 1, 2025
4807c36
Merge branch 'main' into wr-132413
neonene Jul 1, 2025
a5f2521
move test to test_gc.py
neonene Jul 3, 2025
d7c36b9
add and move test case
neonene Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simply do not GC-untrack/track 
The given module can already be untracked.
  • Loading branch information
@neonene
neonene authored Jul 1, 2025
commit fdfadf0b79d9651d9d8213bd8ad08f786809f8ba
22 changes: 12 additions & 10 deletions Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1558,18 +1558,23 @@ finalize_remove_modules(PyObject *modules, int verbose)
if (weaklist != NULL) { \
PyObject *wr = PyWeakref_NewRef(mod, NULL); \
if (wr) { \
PyObject *list = Py_REFCNT(wr) <= 1 ? weaklist : weak_ext; \
PyObject *tup = PyTuple_Pack(2, name, wr); \
if (!tup || PyList_Append(list, tup) < 0) { \
PyErr_FormatUnraisable("Exception ignored while removing modules"); \
} \
if (list == weak_ext) { \
PyObject *list; \
PyObject *tup; \
if (Py_REFCNT(wr) > 1) { \
/* gh-132413: When the weakref is already used elsewhere,
* finalize_modules_clear_weaklist() rather than the GC
* should clear the referenced module since the GC tries
* to clear the wrakref first. The weaklist requires the
* order in which such modules are cleared first. */ \
_PyObject_GC_UNTRACK(mod); \
tup = PyTuple_Pack(3, name, wr, mod); \
list = weak_ext; \
} \
else { \
tup = PyTuple_Pack(2, name, wr); \
list = weaklist; \
} \
if (!tup || PyList_Append(list, tup) < 0) { \
PyErr_FormatUnraisable("Exception ignored while removing modules"); \
} \
Py_XDECREF(tup); \
Py_DECREF(wr); \
Expand Down Expand Up @@ -1678,9 +1683,6 @@ finalize_modules_clear_weaklist(PyInterpreterState *interp,
continue;
}
assert(PyModule_Check(mod));
if (!_PyObject_GC_IS_TRACKED(mod)) {
_PyObject_GC_TRACK(mod);
}
PyObject *dict = _PyModule_GetDict(mod); // borrowed reference
if (dict == interp->builtins || dict == interp->sysdict) {
Py_DECREF(mod);
Expand Down