Skip to content

gh-134584: Eliminate redundant refcounting from _CALL_ISINSTANCE #136077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noamcohen97 wants to merge 6 commits into from
Closed

gh-134584: Eliminate redundant refcounting from _CALL_ISINSTANCE #136077

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a286004
eliminate refcount from `_CALL_ISINSTANCE`
noamcohen97 Jun 28, 2025
3d0f5d3
news entry
noamcohen97 Jun 28, 2025
6c04f67
add test case
noamcohen97 Jun 28, 2025
f2b4400
make sure we also close `callable`
noamcohen97 Jun 28, 2025
cf6e8ef
remove redundant empty line
noamcohen97 Jun 28, 2025
f081274
remove immortal assertion since `isinstance` is mortal
noamcohen97 Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test case
  • Loading branch information
@noamcohen97
noamcohen97 committed Jun 28, 2025
commit 6c04f676c774b5f37766f35f2b5cbc66c649e573
13 changes: 13 additions & 0 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2093,6 +2093,19 @@ def testfunc(n):
self.assertNotIn("_POP_CALL_ONE_LOAD_CONST_INLINE_BORROW", uops)
self.assertNotIn("_POP_CALL_TWO_LOAD_CONST_INLINE_BORROW", uops)

def test_call_isinstance_guards_pop_top(self):

@tomasr8 tomasr8 Jul 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't leave a comment on that line, but inside test_call_isinstance_guards_removed we should include the new opcode _SWAP_CALL_TWO_LOAD_CONST_INLINE_BORROW to ensure remove_unneeded_uops is still working as expected (I think it should be since you also updated op_without_push, but just to be sure :))

def testfunc(n):
x = 0
for _ in range(n):
x += isinstance(42, int)
return x

res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
self.assertEqual(res, TIER2_THRESHOLD)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_POP_TOP_NOP", uops)

def test_call_list_append(self):
def testfunc(n):
a = []
Expand Down