Skip to content

[3.14] GH-135171: Revert async generator expressions behavior #135352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 4 commits into from
Jun 16, 2025
Merged

[3.14] GH-135171: Revert async generator expressions behavior #135352

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d04629b
[3.14] GH-135171: Revert async generator expressions behavior
efimov-mikhail Jun 10, 2025
53bd362
[3.14] GH-135171: Bug fix, test improved
efimov-mikhail Jun 10, 2025
75e6184
[3.14] GH-135171: Bug fix 2, all related changes in codegen.c are rev…
efimov-mikhail Jun 10, 2025
549cd11
Test for async generator is added
efimov-mikhail Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[3.14] GH-135171: Bug fix 2, all related changes in codegen.c are rev… 
…erted
  • Loading branch information
@efimov-mikhail
efimov-mikhail committed Jun 10, 2025
commit 75e6184c8b924178fbbbb9fea32f201573b0840f
5 changes: 1 addition & 4 deletions Python/codegen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4411,7 +4411,6 @@ codegen_sync_comprehension_generator(compiler *c, location loc,

comprehension_ty gen = (comprehension_ty)asdl_seq_GET(generators,
gen_index);
int is_outer_genexpr = gen_index == 0 && type == COMP_GENEXP;
if (!iter_on_stack) {
if (gen_index == 0) {
assert(METADATA(c)->u_argcount == 1);
Expand Down Expand Up @@ -4442,15 +4441,13 @@ codegen_sync_comprehension_generator(compiler *c, location loc,
}
if (IS_JUMP_TARGET_LABEL(start)) {
VISIT(c, expr, gen->iter);
ADDOP(c, LOC(gen->iter), GET_ITER);
}
}
}

if (IS_JUMP_TARGET_LABEL(start)) {
depth++;
if (!is_outer_genexpr) {
ADDOP(c, LOC(gen->iter), GET_ITER);
}
USE_LABEL(c, start);
ADDOP_JUMP(c, LOC(gen->iter), FOR_ITER, anchor);
}
Expand Down