Skip to content

[3.13] GH-135171: Fix generator expressions one last time (hopefully) (GH-135225) #135293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markshannon wants to merge 3 commits into from
Closed

[3.13] GH-135171: Fix generator expressions one last time (hopefully) (GH-135225) #135293

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1749531
Backport 135115
markshannon Jun 9, 2025
9e24a5c
Fix copy-and-paste errors
markshannon Jun 9, 2025
025d453
Update test_dis
markshannon Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test_dis
  • Loading branch information
@markshannon
markshannon committed Jun 9, 2025
commit 025d45368a1b9c37823a4eb0e88824a2e457041f
3 changes: 2 additions & 1 deletion Lib/test/test_dis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ def bug1333982(x=[]):
LOAD_CONST 1 (<code object <genexpr> at 0x..., file "%s", line %d>)
MAKE_FUNCTION
LOAD_FAST 0 (x)
GET_ITER
CALL 0

%3d LOAD_CONST 2 (1)
Expand Down Expand Up @@ -764,6 +765,7 @@ def foo(x):
MAKE_FUNCTION
SET_FUNCTION_ATTRIBUTE 8 (closure)
LOAD_DEREF 1 (y)
GET_ITER
CALL 0
CALL 1
RETURN_VALUE
Expand All @@ -784,7 +786,6 @@ def foo(x):
POP_TOP
L1: RESUME 0
LOAD_FAST 0 (.0)
GET_ITER
L2: FOR_ITER 10 (to L3)
STORE_FAST 1 (z)
LOAD_DEREF 2 (x)
Expand Down