Skip to content

gh-134819: Add sys.set_object_tags and sys.get_object_tags #135073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corona10 wants to merge 13 commits into from
Closed

gh-134819: Add sys.set_object_tags and sys.get_object_tags #135073

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2cc543c
gh-134819: Add sys.set_object_tags and sys.get_object_tags
corona10 Jun 3, 2025
17ccccf
Add test
corona10 Jun 3, 2025
fb997ab
Add set_object_tag
corona10 Jun 3, 2025
5027d35
Add NEWS.d
corona10 Jun 3, 2025
ba2c974
nit
corona10 Jun 3, 2025
658e731
nit
corona10 Jun 3, 2025
e725c7f
fix
corona10 Jun 3, 2025
1cdc798
Update
corona10 Jun 3, 2025
dbc30b7
Address code review
corona10 Jun 3, 2025
e7d06b6
nit
corona10 Jun 3, 2025
ff34816
Address code review
corona10 Jun 3, 2025
4e1946f
nit
corona10 Jun 3, 2025
2a0eb8e
Update
corona10 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@corona10
corona10 committed Jun 3, 2025
commit e725c7f182b95f6dc4747a67e4a5e4aa5192300a
2 changes: 1 addition & 1 deletion Lib/test/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ def __hash__(self):

@support.cpython_only
def test_get_object_tags(self):
keys = ("immortal", "interned", "deferred_refcount")
keys = ("immortal", "interned")
s = "foobar"
tags = sys.get_object_tags(s)
self.assertEqual(len(tags), len(keys))
Expand Down
13 changes: 0 additions & 13 deletions Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,19 +1095,6 @@ sys_get_object_tags(PyObject *module, PyObject *op)
return NULL;
}
}

if (PyUnstable_Object_EnableDeferredRefcount(op)) {
if (PyDict_SetItemString(dict, "deferred_refcount", Py_True) < 0) {
Py_DECREF(dict);
return NULL;
}
}
else {
if (PyDict_SetItemString(dict, "deferred_refcount", Py_False) < 0) {
Py_DECREF(dict);
return NULL;
}
}
return dict;
}

Expand Down