Skip to content

gh-91048: Refactor and optimize remote debugging module #134652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 20 commits into from
May 25, 2025
Merged

gh-91048: Refactor and optimize remote debugging module #134652

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
38f9ad0
gh-91048: Refactor and optimize remote debugging module
pablogsal May 25, 2025
a6fed05
Fix free threading
pablogsal May 25, 2025
8c01234
Fix lint
pablogsal May 25, 2025
1130f27
Simplify stuff and fix free threading caching
pablogsal May 25, 2025
e112a4a
Fix clinic
pablogsal May 25, 2025
559d44f
fix windows
pablogsal May 25, 2025
5b4d67d
Fix arm
pablogsal May 25, 2025
9033b20
Fix lint
pablogsal May 25, 2025
db35f6e
Small fix
pablogsal May 25, 2025
1773d78
Simplofy cleanup
pablogsal May 25, 2025
e2ad532
Small fix
pablogsal May 25, 2025
eb61f38
Fix race in test (two threads need two ready markers!)
ambv May 25, 2025
5da486c
Fix windows
pablogsal May 25, 2025
d6d0c7e
Fix windows
pablogsal May 25, 2025
5bdfec1
Fix windows
pablogsal May 25, 2025
f463436
Regen files
pablogsal May 25, 2025
416d96b
MOAR WINDOWS
pablogsal May 25, 2025
681ab63
Regen morefiles
pablogsal May 25, 2025
14a5f58
More windows stuff
pablogsal May 25, 2025
89311c9
Regen frozenmain
ambv May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix windows
  • Loading branch information
@pablogsal
pablogsal committed May 25, 2025
commit 5bdfec1a5dbebca656ca4fad8c9a6510fc9e2113
11 changes: 4 additions & 7 deletions Modules/_remote_debugging_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,18 @@
// Calculate the minimum buffer size needed to read interpreter state fields
// We need to read code_object_generation and potentially tlbc_generation
#ifndef MAX
#define _MAX(a, b) ((a) > (b) ? (a) : (b))
#else
#define _MAX(a, b) MAX(a, b)
#define MAX(a, b) ((a) > (b) ? (a) : (b))
#endif

#ifdef Py_GIL_DISABLED
#define INTERP_STATE_MIN_SIZE _MAX(_MAX(offsetof(PyInterpreterState, _code_object_generation) + sizeof(uint64_t), \
#define INTERP_STATE_MIN_SIZE MAX(MAX(offsetof(PyInterpreterState, _code_object_generation) + sizeof(uint64_t), \
offsetof(PyInterpreterState, tlbc_indices.tlbc_generation) + sizeof(uint32_t)), \
offsetof(PyInterpreterState, threads.head) + sizeof(void*))
#else
#define INTERP_STATE_MIN_SIZE _MAX(offsetof(PyInterpreterState, _code_object_generation) + sizeof(uint64_t), \
#define INTERP_STATE_MIN_SIZE MAX(offsetof(PyInterpreterState, _code_object_generation) + sizeof(uint64_t), \
offsetof(PyInterpreterState, threads.head) + sizeof(void*))
#endif
#define INTERP_STATE_BUFFER_SIZE _MAX(INTERP_STATE_MIN_SIZE, 256)
#undef _MAX
#define INTERP_STATE_BUFFER_SIZE MAX(INTERP_STATE_MIN_SIZE, 256)



Expand Down