Skip to content

gh-134635: add zlib.{adler32,crc32}_combine to combine checksums #134650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 10 commits into from
May 27, 2025
Merged

gh-134635: add zlib.{adler32,crc32}_combine to combine checksums #134650

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f71608e
expose `zlib.{adler32,crc32}_combine`
picnixz May 25, 2025
c8a96c8
update docs
picnixz May 25, 2025
c67d7ba
Address doc review's feedback
picnixz May 25, 2025
0540501
Update What's New
picnixz May 25, 2025
c5a2c55
add a failing test
picnixz May 25, 2025
cc160a7
update clinic
picnixz May 26, 2025
f3fca34
remove rST syntax in clinic
picnixz May 26, 2025
2c34e5f
add type checks
picnixz May 26, 2025
86746bd
Merge branch 'main' into feat/zlib/crc32-combine-134635
picnixz May 26, 2025
2753b18
Apply suggestions from code review
picnixz May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address doc review's feedback
  • Loading branch information
@picnixz
picnixz authored May 25, 2025
commit c67d7badbae83e99221509fbf0600b6ecfb1b220
20 changes: 14 additions & 6 deletions Doc/library/zlib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,13 @@ The available exception and functions in this module are:

Combine two Adler-32 checksums into one.

Given an Adler-32 check value *adler1* of a sequence A and an Adler-32 check
value *adler2* of a sequence B of length *len2*, the returned checksum
is the Adler-32 check value of A and B concatenated.
Given the Adler-32 checksum *adler1* of a sequence ``A`` and the
Adler-32 checksum *adler2* of a sequence ``B`` of length *len2*,
return the Adler-32 checksum of ``A`` and ``B`` concatenated.

This function is typically useful to combine Adler-32 checksums
that were concurrently computed. To compute checksums from a stream
of chunks, use :func:`adler32` sequentially instead.
Comment thread
picnixz marked this conversation as resolved.
Outdated

.. versionadded:: next

Expand Down Expand Up @@ -150,9 +154,13 @@ The available exception and functions in this module are:

Combine two CRC-32 checksums into one.

Given a CRC-32 check value *crc1* of a sequence A and a CRC-32 check
value *crc2* of a sequence B of length *len2*, the returned checksum
is the CRC-32 check value of A and B concatenated.
Given the CRC-32 checksum *crc1* of a sequence ``A`` and the
CRC-32 checksum *crc2* of a sequence ``B`` of length *len2*,
return the CRC-32 checksum of ``A`` and ``B`` concatenated.

This function is typically useful to combine CRC-32 checksums
that were concurrently computed. To compute checksums from a
stream of chunks, use :func:`crc32` sequentially instead.
Comment thread
picnixz marked this conversation as resolved.
Outdated

.. versionadded:: next

Expand Down