Skip to content

gh-101525: Use only safe identical code folding with BOLT #134642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geofft wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-101525: Use only safe identical code folding with BOLT #134642

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91fc5ae
Use only safe identical code folding with BOLT
geofft May 24, 2025
c28b7ec
Use WITH_SAVE_ENV and avoid unnecessary brackets
geofft Sep 11, 2026
8c0e9c1
Merge remote-tracking branch 'origin/main' into safe-icf
geofft Sep 11, 2026
4a90c16
autoreconf
geofft Sep 11, 2026
7be8273
Add blurb
geofft Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use WITH_SAVE_ENV and avoid unnecessary brackets 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
  • Loading branch information
@geofft @erlend-aasland
geofft and erlend-aasland authored Sep 11, 2026
commit c28b7ec4197992b48e3583910174673c79ea8dbb
22 changes: 10 additions & 12 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,18 +2135,16 @@ if test "$Py_BOLT" = 'true' ; then
[whether ${LLVM_BOLT} supports safe identical code folding],
[py_cv_bolt_icf_safe],
[
saved_cflags="$CFLAGS"
saved_ldflags="$LDFLAGS"
CFLAGS="$CFLAGS_NODIST"
LDFLAGS="$LDFLAGS_NODIST"
AC_LINK_IFELSE(
[AC_LANG_PROGRAM([[]], [[]])],
[py_cv_bolt_icf_safe=no
${LLVM_BOLT} -icf=safe -o conftest.bolt conftest$EXEEXT >&AS_MESSAGE_LOG_FD 2>&1 dnl
&& py_cv_bolt_icf_safe=yes],
[AC_MSG_FAILURE([could not compile empty test program])])
CFLAGS="$saved_cflags"
LDFLAGS="$saved_ldflags"
WITH_SAVE_ENV([
CFLAGS="$CFLAGS_NODIST"
LDFLAGS="$LDFLAGS_NODIST"
AC_LINK_IFELSE(
[AC_LANG_PROGRAM([], [])],
[py_cv_bolt_icf_safe=no
${LLVM_BOLT} -icf=safe -o conftest.bolt conftest$EXEEXT >&AS_MESSAGE_LOG_FD 2>&1 dnl
&& py_cv_bolt_icf_safe=yes],
[AC_MSG_FAILURE([could not compile empty test program])])
])
]
)
if test "$py_cv_bolt_icf_safe" = no; then
Expand Down