Skip to content

gh-69605: Disable PyREPL module autocomplete fallback on regular completion #134181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 7 commits into from
May 25, 2025
Merged

gh-69605: Disable PyREPL module autocomplete fallback on regular completion #134181

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8978e95
PyREPL module autocomplete: do not fallback
loic-simon May 18, 2025
ccfdf43
📜🤖 Added by blurb_it.
blurb-it[bot] May 18, 2025
377c761
Improve blurb wording
loic-simon May 19, 2025
99e1980
Get rid of assignment expression
loic-simon May 19, 2025
dd5940e
Move tests to a dedicated method
loic-simon May 19, 2025
84c4f76
Tests: mock sys.path in setUp instead
loic-simon May 20, 2025
719875e
Remove extra docstring line
loic-simon May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Get rid of assignment expression
  • Loading branch information
@loic-simon
loic-simon committed May 19, 2025
commit 99e1980802cc8519e4494055bde9e37a8318c9e8
3 changes: 2 additions & 1 deletion Lib/_pyrepl/readline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ def get_stem(self) -> str:
return "".join(b[p + 1 : self.pos])

def get_completions(self, stem: str) -> list[str]:
if (module_completions := self.get_module_completions()) is not None:
module_completions = self.get_module_completions()
if module_completions is not None:
return module_completions
if len(stem) == 0 and self.more_lines is not None:
b = self.buffer
Expand Down