Skip to content

[3.14] gh-77065: add missing parameter echo_char in getpass.fallback_getpass (GH-133849) #134053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 1 commit into from
May 15, 2025
Merged

[3.14] gh-77065: add missing parameter echo_char in getpass.fallback_getpass (GH-133849) #134053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-77065: add missing parameter echo_char in `getpass.fallback_getp… 
…ass` (GH-133849)

(cherry picked from commit d029a1a)

Co-authored-by: Semyon Moroz <donbarbos@proton.me>
  • Loading branch information
@donbarbos @miss-islington
donbarbos authored and miss-islington committed May 15, 2025
commit f9d493b83b66c9c597de7c8a3edc3e3099b06abf
5 changes: 3 additions & 2 deletions Lib/getpass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,15 @@ def win_getpass(prompt='Password: ', stream=None, *, echo_char=None):
return pw


def fallback_getpass(prompt='Password: ', stream=None):
def fallback_getpass(prompt='Password: ', stream=None, *, echo_char=None):
_check_echo_char(echo_char)
import warnings
warnings.warn("Can not control echo on the terminal.", GetPassWarning,
stacklevel=2)
if not stream:
stream = sys.stderr
print("Warning: Password input may be echoed.", file=stream)
return _raw_input(prompt, stream)
return _raw_input(prompt, stream, echo_char=echo_char)


def _check_echo_char(echo_char):
Expand Down