Skip to content

gh-132983: Convert dict_content to take Py_buffer #133924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 6 commits into from
May 26, 2025
Merged

gh-132983: Convert dict_content to take Py_buffer #133924

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
42782b8
Convert dict_content to take Py_buffer
AA-Turner May 11, 2025
7c0d002
Respond to review comments
AA-Turner May 24, 2025
30ac9d5
Respond to review comments (2)
AA-Turner May 26, 2025
e40de15
fixup! Respond to review comments (2)
AA-Turner May 26, 2025
feb034d
Improve error
AA-Turner May 26, 2025
c36f62d
delete full stop
AA-Turner May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve error
  • Loading branch information
@AA-Turner
AA-Turner committed May 26, 2025
commit feb034df5833604fbe0374896b2cebc877db8dbc
6 changes: 3 additions & 3 deletions Modules/_zstd/zstddict.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ _zstd_ZstdDict_new_impl(PyTypeObject *type, Py_buffer *dict_content,
/* All dictionaries must be at least 8 bytes */
if (dict_content->len < 8) {
PyErr_SetString(PyExc_ValueError,
"Zstandard dictionary content must be longer "
"than eight bytes.");
"Zstandard dictionary content too short "
"(must have at least eight bytes)");
return NULL;
}

Expand Down Expand Up @@ -89,7 +89,7 @@ _zstd_ZstdDict_new_impl(PyTypeObject *type, Py_buffer *dict_content,

PyObject_GC_Track(self);

return (PyObject*)self;
return (PyObject *)self;

error:
Py_XDECREF(self);
Expand Down