Skip to content

gh-132983: Split _zstd_set_c_parameters #133921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 17 commits into from
May 28, 2025
Merged

gh-132983: Split _zstd_set_c_parameters #133921

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d44dd9b
Split _zstd_set_c_parameters
AA-Turner May 11, 2025
6f58a95
Merge remote-tracking branch 'upstream/main' into zstd-set-params
AA-Turner May 24, 2025
f40f008
Respond to review comments
AA-Turner May 24, 2025
1fb521a
fixup! Respond to review comments
AA-Turner May 24, 2025
86860c8
Merge remote-tracking branch 'upstream/main' into zstd-set-params
AA-Turner May 26, 2025
5b851a2
Serhiy's review
AA-Turner May 26, 2025
83297c9
Merge remote-tracking branch 'upstream/main' into zstd-set-params
AA-Turner May 26, 2025
6b3c744
Merge remote-tracking branch 'refs/remotes/upstream/main' into zstd-s…
AA-Turner May 26, 2025
36a4517
Serhiy's review
AA-Turner May 26, 2025
4b2b442
error messages
AA-Turner May 27, 2025
316195d
Merge remote-tracking branch 'upstream/main' into zstd-set-params
AA-Turner May 27, 2025
5636fd8
Merge remote-tracking branch 'upstream/main' into zstd-set-params
AA-Turner May 28, 2025
62d085e
restore out-of-bounds tests & improve range notation
AA-Turner May 28, 2025
60eed1a
Merge remote-tracking branch 'upstream/main' into zstd-set-params
AA-Turner May 28, 2025
1e62fd2
fix bad pattern
AA-Turner May 28, 2025
0b37454
Apply suggestion
AA-Turner May 28, 2025
c877a4f
negative
AA-Turner May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Respond to review comments
  • Loading branch information
@AA-Turner
AA-Turner committed May 24, 2025
commit 1fb521a4661e2630082e5384851cf8461359ff60
2 changes: 0 additions & 2 deletions Modules/_zstd/compressor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,8 +714,6 @@ PyDoc_STRVAR(ZstdCompressor_last_mode_doc,
static PyMemberDef ZstdCompressor_members[] = {
{"last_mode", Py_T_INT, offsetof(ZstdCompressor, last_mode),
Py_READONLY, ZstdCompressor_last_mode_doc},
{"compression_level", Py_T_INT, offsetof(ZstdCompressor, compression_level),
Py_READONLY, NULL},
{NULL}
};

Expand Down