Skip to content

gh-132983: Reduce the size of _zstdmodule.h #133793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 10 commits into from
May 10, 2025
Merged

gh-132983: Reduce the size of _zstdmodule.h #133793

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b158d3f
Rename inited to initialized, convert to bool
AA-Turner May 9, 2025
ae9e303
Move mt_continue_should_break()
AA-Turner May 9, 2025
d2e189f
Move enum decompress_type
AA-Turner May 9, 2025
8e5e1ca
Add guard defines
AA-Turner May 10, 2025
161b826
Use angle-bracket includes
AA-Turner May 10, 2025
942be5b
Reduce transitive includes
AA-Turner May 10, 2025
a71aa3c
Remove Zstd{Compressor,Decompressor,Dict} from _zstdmodule.h
AA-Turner May 10, 2025
9548b6a
Make _zstdmodule static
AA-Turner May 10, 2025
223216d
regen-all
AA-Turner May 10, 2025
bb20445
Bénédikt's review
AA-Turner May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Bénédikt's review
  • Loading branch information
@AA-Turner
AA-Turner committed May 10, 2025
commit bb204455b4ff78402b9c4918897a0cf1e2773589
3 changes: 1 addition & 2 deletions Modules/_zstd/_zstdmodule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Python module.

#ifndef ZSTD_MODULE_H
Comment thread
AA-Turner marked this conversation as resolved.
#define ZSTD_MODULE_H
#include "Python.h"

/* Type specs */
extern PyType_Spec zstd_dict_type_spec;
Expand Down Expand Up @@ -56,4 +55,4 @@ extern void
set_parameter_error(const _zstd_state* const state, int is_compress,
int key_v, int value_v);

#endif
#endif // !ZSTD_MODULE_H
4 changes: 2 additions & 2 deletions Modules/_zstd/buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Python module.

#ifndef ZSTD_BUFFER_H
Comment thread
AA-Turner marked this conversation as resolved.
#define ZSTD_BUFFER_H
#include "Python.h"

#include "pycore_blocks_output_buffer.h"

#include <zstd.h> // ZSTD_outBuffer
Expand Down Expand Up @@ -107,4 +107,4 @@ _OutputBuffer_ReachedMaxLength(_BlocksOutputBuffer *buffer, ZSTD_outBuffer *ob)
return buffer->allocated == buffer->max_length;
}

#endif
#endif // !ZSTD_BUFFER_H
4 changes: 2 additions & 2 deletions Modules/_zstd/compressor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ Python module.

/*[clinic input]
module _zstd
class _zstd.ZstdCompressor "ZstdCompressor *" "zstd_compressor_type_spec"
class _zstd.ZstdCompressor "ZstdCompressor *" "&zstd_compressor_type_spec"
[clinic start generated code]*/
/*[clinic end generated code: output=da39a3ee5e6b4b0d input=842f2c4f4520ab26]*/
/*[clinic end generated code: output=da39a3ee5e6b4b0d input=7166021db1ef7df8]*/

#ifndef Py_BUILD_CORE_BUILTIN
# define Py_BUILD_CORE_MODULE 1
Expand Down
3 changes: 1 addition & 2 deletions Modules/_zstd/zstddict.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Python module.

#ifndef ZSTD_DICT_H
#define ZSTD_DICT_H
#include "Python.h"

#include <stdbool.h> // bool
#include <zstd.h> // ZSTD_DDict
Expand All @@ -29,4 +28,4 @@ typedef struct {
bool initialized;
} ZstdDict;

#endif
#endif // !ZSTD_DICT_H