Skip to content

gh-125996: fix thread safety of ordered dict #133734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 10 commits into from
Oct 13, 2025
Merged

gh-125996: fix thread safety of ordered dict #133734

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1373660
fix thread safety of ordered dict
kumaraditya303 May 8, 2025
72ba12a
📜🤖 Added by blurb_it.
blurb-it[bot] May 10, 2025
bbd7487
fmt
kumaraditya303 May 19, 2025
ef2aed1
use lock held clear of dict
kumaraditya303 May 27, 2025
473cfa0
remove unused function
kumaraditya303 May 27, 2025
4bf573e
use critical section on iterator
kumaraditya303 Jul 5, 2025
9d1ae53
use PyDict_Clear
kumaraditya303 Jul 5, 2025
587dae8
Merge remote-tracking branch 'upstream/main' into ordereddict
kumaraditya303 Oct 8, 2025
4d8e596
Update Objects/odictobject.c
kumaraditya303 Oct 13, 2025
22b3b72
Merge branch 'main' into ordereddict
kumaraditya303 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use PyDict_Clear
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Jul 5, 2025
commit 9d1ae536c24828269c387021ba8ce5f6e6e60ca8
3 changes: 2 additions & 1 deletion Objects/odictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,7 +1475,8 @@ odict_tp_clear(PyObject *op)
{
PyODictObject *od = _PyODictObject_CAST(op);
Py_CLEAR(od->od_inst_dict);
_PyDict_Clear_LockHeld((PyObject *)od);
// cannot use lock held variant as critical section is not held here
PyDict_Clear(op);
_odict_clear_nodes(od);
return 0;
}
Expand Down