Skip to content

gh-61103: don't use native complex types in ctypes #133237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 6 commits into from
May 5, 2025
Merged

gh-61103: don't use native complex types in ctypes #133237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66d7e54
gh-121249: make complex types available unconditionally in the struct…
skirpichev Apr 24, 2025
6a20faf
gh-61103: don't use native complex types to implement F/D/G in ctypes
skirpichev Apr 30, 2025
8bbed73
Update Modules/_struct.c
skirpichev May 1, 2025
f1fa51b
Apply suggestions from code review
skirpichev May 1, 2025
071d57e
Update Misc/NEWS.d/next/Library/2025-04-25-16-20-49.gh-issue-121249.u…
skirpichev May 1, 2025
b18d895
Merge branch 'main' into no_complex.h/61103
skirpichev May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
  • Loading branch information
@skirpichev @encukou
skirpichev and encukou authored May 1, 2025
commit f1fa51bab386a2323aefc9e82570866361c6ce4a
9 changes: 4 additions & 5 deletions Doc/library/struct.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,11 +360,10 @@ Notes:
For the ``'E'`` and ``'C'`` format characters, the packed representation uses
Comment thread
skirpichev marked this conversation as resolved.
Outdated
the IEEE 754 binary32 and binary64 format for components of the complex
number, regardless of the floating-point format used by the platform.
Note that support for complex types is available unconditionally,
regardless on support IEC 60559 compatible complex arithmetic (Annex G of
the C11 standard) by the compiler. Each complex type is interpreted as an
array type containing exactly two elements of the corresponding real type
(real and imaginary parts, respectively).
Note that complex types (``F`` and ``D``) are available unconditionally,
despite complex types being an optional feature in C.
As specified in the C11 standard, each complex type is represented by a
two-element C array containing, respectively, the real and imaginary parts.


A format character may be preceded by an integral repeat count. For example,
Expand Down
2 changes: 1 addition & 1 deletion Modules/_ctypes/cfield.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ d_get(void *ptr, Py_ssize_t size)

#if defined(Py_FFI_SUPPORT_C_COMPLEX)

/* We don't use Annex G complex types here, using arrays instead, as the C17+
/* We don't use _Complex types here, using arrays instead, as the C11+
standard says: "Each complex type has the same representation and alignment
requirements as an array type containing exactly two elements of the
corresponding real type; the first element is equal to the real part, and
Expand Down