Skip to content

gh-91048: Chain some exceptions in _testexternalinspection.c #132970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 8 commits into from
May 2, 2025
Merged

gh-91048: Chain some exceptions in _testexternalinspection.c #132970

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0664231
Add Py_UNREACHABLE
sergey-miryanov Apr 25, 2025
cd9a499
Remove unused refcnt
sergey-miryanov Apr 25, 2025
3ed2837
Reset result if can not close file descriptor
sergey-miryanov Apr 25, 2025
cc46cc2
Set exception only if not set
sergey-miryanov Apr 25, 2025
6a72bf9
Chain exception to get more info
sergey-miryanov Apr 25, 2025
6466cf9
Remove error string from macos impl to keep PermissionError
sergey-miryanov Apr 25, 2025
e718330
Replace macro with static function
sergey-miryanov Apr 25, 2025
40e099b
Remove chain_exceptions from remote_debug to make clang on macos happy
sergey-miryanov Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set exception only if not set
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed Apr 25, 2025
commit cc46cc28d9d20ae5180e3d8e69583a1afe5e6dc0
4 changes: 3 additions & 1 deletion Python/remote_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,9 @@ search_map_for_section(proc_handle_t *handle, const char* secname, const char* s

mach_port_t proc_ref = pid_to_task(handle->pid);
if (proc_ref == 0) {
PyErr_SetString(PyExc_PermissionError, "Cannot get task for PID");
if (!PyErr_Occurred()) {
PyErr_SetString(PyExc_PermissionError, "Cannot get task for PID");
}
return 0;
}

Expand Down