Skip to content

GH-130328: further speedup of pasting in new REPL on Windows by reading in chunks #132889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chris-eibl wants to merge 14 commits into from
Closed

GH-130328: further speedup of pasting in new REPL on Windows by reading in chunks #132889

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0a38c2e
fix WindowsConsole.wait()
chris-eibl Apr 24, 2025
05d26ff
blurb it
chris-eibl Apr 24, 2025
cad6bfb
fix timeout=None
chris-eibl Apr 24, 2025
3d1da66
fix mypy for ctypes.get_last_error
chris-eibl Apr 24, 2025
4098e3d
fix return value of wait() and use it in _read_input()
chris-eibl Apr 24, 2025
a64f4c4
read in chunks
chris-eibl Apr 24, 2025
937b6bd
fix missing return in getpending
chris-eibl Apr 24, 2025
bba26c9
use self.paste_mode instead of self.in_bracketed_paste
chris-eibl Apr 28, 2025
9794664
Merge branch 'fix_wait' into read_chunked
chris-eibl Apr 28, 2025
3c0cae9
Revert "use self.paste_mode instead of self.in_bracketed_paste"
chris-eibl Apr 28, 2025
b6ea252
Merge branch 'fix_wait' into read_chunked
chris-eibl Apr 28, 2025
8fa84d1
Merge branch 'main' into read_chunked
chris-eibl May 2, 2025
5b055f1
remove copying of the raw member of Event, because
chris-eibl May 2, 2025
a7ebeed
Merge branch 'read_chunked' of https://github.com/chris-eibl/cpython …
chris-eibl May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix return value of wait() and use it in _read_input()
  • Loading branch information
@chris-eibl
chris-eibl committed Apr 24, 2025
commit 4098e3d5de951fbac4b7db95fbf2f333366d1d8c
11 changes: 5 additions & 6 deletions Lib/_pyrepl/windows_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,12 +416,8 @@ def _getscrollbacksize(self) -> int:
return info.srWindow.Bottom # type: ignore[no-any-return]

def _read_input(self, block: bool = True) -> INPUT_RECORD | None:
if not block:
ret = WaitForSingleObject(InHandle, 0)
if ret == WAIT_FAILED:
raise WinError(get_last_error())
elif ret == WAIT_TIMEOUT:
return None
if not block and not self.wait(timeout=0):
return None

rec = INPUT_RECORD()
read = DWORD()
Expand Down Expand Up @@ -536,6 +532,9 @@ def wait(self, timeout: float | None) -> bool:
ret = WaitForSingleObject(InHandle, timeout)
if ret == WAIT_FAILED:
raise WinError(get_last_error())
elif ret == WAIT_TIMEOUT:
return False
return True

def repaint(self) -> None:
raise NotImplementedError("No repaint support")
Expand Down