Skip to content

gh-132426: get_annotate_function vs. mapping namespaces #132427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eliegoudout wants to merge 2 commits into from
Closed

gh-132426: get_annotate_function vs. mapping namespaces #132427

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93afac8
fix: ns can be mapping (closes #132426)
eliegoudout Apr 12, 2025
a4ad2c6
Mapping from collections.abc, local
eliegoudout Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mapping from collections.abc, local 
Signed-off-by: Élie Goudout <eliegoudout@hotmail.com>
  • Loading branch information
@eliegoudout
eliegoudout committed Apr 12, 2025
commit a4ad2c6a34ccbc194754ee98915fa31f22d7313e
5 changes: 3 additions & 2 deletions Lib/annotationlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import keyword
import sys
import types
import typing

__all__ = [
"Format",
Expand Down Expand Up @@ -628,7 +627,9 @@ def get_annotate_function(obj):

Returns the __annotate__ function or None.
"""
if isinstance(obj, typing.Mapping):
from collections.abc import Mapping

if isinstance(obj, Mapping):
try:
return obj["__annotate__"]
except KeyError:
Expand Down