Skip to content

gh-132132: Upgrade LLVM on tail calling CI #132098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 17 commits into from
Apr 5, 2025
Merged

gh-132132: Upgrade LLVM on tail calling CI #132098

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
701aa8d
Fix double redeclaration on MSVC+clang-cl
Fidget-Spinner Apr 4, 2025
e449148
trigger CI
Fidget-Spinner Apr 4, 2025
5eea591
Upgrade to LLVM 20
Fidget-Spinner Apr 4, 2025
fcb45ef
Fix
Fidget-Spinner Apr 4, 2025
ce1a4ae
fix macos
Fidget-Spinner Apr 4, 2025
d2002cd
fix macOS
Fidget-Spinner Apr 4, 2025
c8afa07
fix macOS for real this time
Fidget-Spinner Apr 4, 2025
728eb68
maybe fix macOS?
Fidget-Spinner Apr 4, 2025
bc1d927
Convince clang to behave like on Linux
Fidget-Spinner Apr 4, 2025
a468604
remove useless extern
Fidget-Spinner Apr 4, 2025
07cafa9
Update remote_debugging.c
Fidget-Spinner Apr 4, 2025
bd00b78
Update remote_debugging.c
Fidget-Spinner Apr 4, 2025
04d34df
Update remote_debugging.c
Fidget-Spinner Apr 4, 2025
5de6b43
revert debug offset changes
Fidget-Spinner Apr 5, 2025
e786fd8
Merge remote-tracking branch 'upstream/main' into fix-double-redeclar…
Fidget-Spinner Apr 5, 2025
e4ff0e0
try eval brew shellenv
Fidget-Spinner Apr 5, 2025
b9c97f6
revert eval
Fidget-Spinner Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update remote_debugging.c
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Apr 4, 2025
commit 04d34df053c5ebe19b887364d31c124de17756b9
2 changes: 1 addition & 1 deletion Python/remote_debugging.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ get_py_runtime(proc_handle_t* handle)
#else
const char* secname = "PyRuntime";
#endif

@chris-eibl chris-eibl Apr 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use secname instead of "PyRuntime" below?

@Fidget-Spinner Fidget-Spinner Apr 4, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah oops 🤦 thanks 3AM things.

address = search_windows_map_for_section(handle, "PyRuntime", L"python");
address = search_windows_map_for_section(handle, secname, L"python");
if (address == 0) {
// Error out: 'python' substring covers both executable and DLL
PyErr_SetString(PyExc_RuntimeError, "Failed to find the PyRuntime section in the process.");
Expand Down