Skip to content

bpo-35712: Make using NotImplemented in a boolean context issue a dep… #13195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 6 commits into from
Mar 3, 2020
Merged

bpo-35712: Make using NotImplemented in a boolean context issue a dep… #13195

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7a1df4
bpo-35712: Make using NotImplemented in a boolean context issue a dep…
MojoVampire May 8, 2019
663add0
Style fixes suggested by serhiy-storchaka
MojoVampire May 8, 2019
f309a02
Moving to 3.9 deprecation from 3.8
MojoVampire Jul 26, 2019
dc357ad
Change NotImplemented docs in datamodel and constants to indicate dep…
MojoVampire Aug 7, 2019
25575c0
Fix formatting and cross-references in docs
MojoVampire Aug 7, 2019
495b61b
Merge branch 'master' into fix-issue-35712
serhiy-storchaka Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Style fixes suggested by serhiy-storchaka
  • Loading branch information
@MojoVampire
MojoVampire committed Aug 1, 2019
commit 663add0a543da5e9ba286a69e3d086684218933b
13 changes: 3 additions & 10 deletions Objects/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,21 +1723,14 @@ notimplemented_bool(PyObject *v)
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"NotImplemented should not be used in a boolean context",
1) < 0)
{
return -1;
Comment thread
MojoVampire marked this conversation as resolved.
Outdated
}
return 1;
}

static PyNumberMethods notimplemented_as_number = {
0, /* nb_add */
0, /* nb_subtract */
0, /* nb_multiply */
0, /* nb_remainder */
0, /* nb_divmod */
0, /* nb_power */
0, /* nb_negative */
0, /* nb_positive */
0, /* nb_absolute */
(inquiry)notimplemented_bool, /* nb_bool */
.nb_bool = notimplemented_bool,
};

PyTypeObject _PyNotImplemented_Type = {
Expand Down