Skip to content

gh-131791: Improve speed of textwrap.dedent by replacing re #131792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Marius-Juston wants to merge 18 commits into from
Closed

gh-131791: Improve speed of textwrap.dedent by replacing re #131792

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b722c23
optimized dedent by 4x for larger files, added only_whitespace option…
Marius-Juston Mar 27, 2025
540b462
removed necessary regex expression
Marius-Juston Mar 27, 2025
2159118
added news entry
Marius-Juston Mar 27, 2025
8cf2153
updated news inline literals backticks
Marius-Juston Mar 27, 2025
7754af3
corrected dedent to pass test cases
Marius-Juston Mar 27, 2025
76f231a
added missing os dependencie
Marius-Juston Mar 27, 2025
8dce5ab
reset what the current doc was
Marius-Juston Mar 27, 2025
520f25f
much simpler implementation, using fileter and common prefix for fast…
Marius-Juston Mar 27, 2025
e703e0d
small mistake for single line
Marius-Juston Mar 27, 2025
159e363
forgot to invert the compairson
Marius-Juston Mar 27, 2025
1c2678e
minor optimization, using lstrip and more concise margin_len computation
Marius-Juston Mar 27, 2025
da9e65c
Merge remote-tracking branch 'origin/main'
Marius-Juston Mar 27, 2025
c7cd5ce
updated variable name
Marius-Juston Mar 27, 2025
3ab30a7
Merge branch 'main' into main
Marius-Juston Mar 27, 2025
199d237
minor faster filtering using list comprehension
Marius-Juston Mar 28, 2025
27fcf53
small speedup by removing ends with
Marius-Juston Mar 28, 2025
1379566
strip seems to give an extremely minor performance boost over lstrip
Marius-Juston Mar 28, 2025
b71240d
fixed unecessary end line operator for empty
Marius-Juston Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added missing os dependencie
  • Loading branch information
@Marius-Juston
Marius-Juston committed Mar 27, 2025
commit 76f231a8e3b13d06e7e4767e00029a35e36e318c
3 changes: 2 additions & 1 deletion Lib/textwrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
# Written by Greg Ward <gward@python.net>

import re
import os

__all__ = ['TextWrapper', 'wrap', 'fill', 'dedent', 'indent', 'shorten']

Expand Down Expand Up @@ -431,7 +432,7 @@ def dedent(text):
return text # Single line has no dedent

# Split text into lines, preserving line endings
lines: List[str] = text.splitlines(keepends=True)
lines = text.splitlines(keepends=True)

# Process in a single pass to find:
# 1. Leading whitespace of non-blank lines
Expand Down