Skip to content

gh-132097: allow AC to disable fastcall convention to avoid UBSan failures #131605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 19 commits into from
Apr 18, 2025
Merged

gh-132097: allow AC to disable fastcall convention to avoid UBSan failures #131605

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ea6e46b
remove unused casts by clinic
picnixz Mar 20, 2025
4001c73
fixup
picnixz Mar 20, 2025
1480166
Revert "fixup"
picnixz Mar 20, 2025
a737ca5
fixup
picnixz Mar 20, 2025
6f20fc9
fixup
picnixz Mar 20, 2025
45f38a7
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Mar 23, 2025
1331a3e
move comments
picnixz Mar 23, 2025
df2d466
move comments
picnixz Mar 23, 2025
dfe5c9d
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Mar 24, 2025
d032ba0
revert cast removal
picnixz Mar 24, 2025
abd0f7c
make clinic
picnixz Mar 24, 2025
54a80c8
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Apr 3, 2025
18022f3
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Apr 4, 2025
0b437c4
GH-131498: Cases generator: manage stacks automatically (GH-132074)
markshannon Apr 4, 2025
e115ce3
gh-99108: Implement HACL* HMAC (#130157)
picnixz Apr 4, 2025
5695216
Merge branch 'main' into fix/ubsan/clinic-test-111178
picnixz Apr 5, 2025
107983d
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Apr 5, 2025
65c64bc
check arguments given to the 'disable' directive
picnixz Apr 5, 2025
eec145e
Merge branch 'main' into fix/ubsan/clinic-test-111178
picnixz Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check arguments given to the 'disable' directive
  • Loading branch information
@picnixz
picnixz committed Apr 5, 2025
commit 65c64bc4809b3a996fe05fd5addba8629df1ba8b
7 changes: 6 additions & 1 deletion Tools/clinic/libclinic/dsl_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,12 @@ def at_disable(self, *args: str) -> None:
fail("Can't set @disable, function is not a normal callable")
if not args:
fail("@disable expects at least one argument")
self.disable_fastcall = 'fastcall' in args
features = list(args)
if 'fastcall' in features:
features.remove('fastcall')
self.disable_fastcall = True
if features:
fail("invalid argument for @disable:", features[0])

def at_getter(self) -> None:
match self.kind:
Expand Down