Skip to content

gh-131524: Update platform CLI to use argparse #131542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 17 commits into from
May 3, 2025
Merged

gh-131524: Update platform CLI to use argparse #131542

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5eed43f
Convert platform CLI to use argparse
Harry-Lees Mar 21, 2025
119de84
Exit using sys.exit(0)
Harry-Lees Mar 21, 2025
994f46f
Parse position and flag arguments
Harry-Lees Mar 21, 2025
a0bb407
test flag parsing
Harry-Lees Mar 21, 2025
a21a6be
Add NEWS entry
Harry-Lees Mar 21, 2025
b4e0ed2
Sort imports alphabetically
Harry-Lees Mar 21, 2025
67cebfd
Sort imports alphabetically
Harry-Lees Mar 21, 2025
9ca5a96
Add help messages to included commands
Harry-Lees Mar 21, 2025
2c9a01c
Add help messages to included commands
Harry-Lees Mar 21, 2025
fb133e1
Use `platform.invalidate_caches()` in test setUp and teardown
Harry-Lees Mar 23, 2025
5fd4601
Fix typo in `Lib/test/test_platform.py`
Harry-Lees Mar 23, 2025
6381470
Update docstring in `text_normalize` function
Harry-Lees Mar 23, 2025
1f230f2
re-flow strings to improve formatting
Harry-Lees Mar 24, 2025
a5dcbf2
Convert shlex call to an array of flags
Harry-Lees Mar 24, 2025
48e3559
Remove redundant textwrap.dedent()
Harry-Lees Apr 24, 2025
cd389f5
Check for start of help command in tests which show help
Harry-Lees Apr 24, 2025
d5e311f
Apply suggestions from code review
hugovk May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Convert shlex call to an array of flags
  • Loading branch information
@Harry-Lees
Harry-Lees committed Mar 24, 2025
commit a5dcbf25c228c6fdc9ff9252f325e5169d75133e
21 changes: 10 additions & 11 deletions Lib/test/test_platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@
import itertools
import pickle
Comment thread
Harry-Lees marked this conversation as resolved.
import platform
import shlex
import subprocess
import sys
Comment thread
Harry-Lees marked this conversation as resolved.
import unittest
from unittest import mock
from textwrap import dedent
Comment thread
Harry-Lees marked this conversation as resolved.
Outdated
Comment thread
Harry-Lees marked this conversation as resolved.
Outdated
from unittest import mock

from test import support
from test.support import os_helper
Expand Down Expand Up @@ -789,19 +788,19 @@ def test_arg_parsing(self):
# `platform.platform()` call. The parameters are two booleans for `aliased`
# and `terse`.
options = (
("--nonaliased", (False, False)),
("nonaliased", (False, False)),
("--terse", (True, True)),
("terse", (True, True)),
("nonaliased terse", (False, True)),
("--nonaliased terse", (False, True)),
("--terse nonaliased", (False, True)),
(["--nonaliased"], (False, False)),
(["nonaliased"], (False, False)),
(["--terse"], (True, True)),
(["terse"], (True, True)),
(["nonaliased", "terse"], (False, True)),
(["--nonaliased", "terse"], (False, True)),
(["--terse", "nonaliased"], (False, True)),
)

for flags, args in options:
with self.subTest(f"{flags}, {args}"):
with self.subTest(flags=flags, args=args):
with mock.patch.object(platform, 'platform') as obj:
self.invoke_platform(*shlex.split(flags))
self.invoke_platform(*flags)
obj.assert_called_once_with(*args)

def test_help(self):
Expand Down