Skip to content

gh-115783: Deprecate support for invalid ISO formats in datetime.fromisoformat #131522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanFromIreland wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-115783: Deprecate support for invalid ISO formats in datetime.fromisoformat #131522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a2f4e4e
Add deprecations-
StanFromIreland Mar 20, 2025
7b52e94
Docs
StanFromIreland Mar 20, 2025
27711ab
clean up
StanFromIreland Mar 20, 2025
b205bd2
changes
StanFromIreland Mar 20, 2025
6c24927
Merge branch 'main' into deprecate-stuff
graingert Mar 29, 2025
5f858c0
Update stack levels
StanFromIreland Mar 29, 2025
dfe4252
Update Modules/_datetimemodule.c
graingert Mar 29, 2025
4e3effc
Ignore warnings
StanFromIreland Mar 29, 2025
74d9b7d
Ignore warnings again
StanFromIreland Mar 29, 2025
42e5adb
bump stacklevel
StanFromIreland Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore warnings again
  • Loading branch information
@StanFromIreland
StanFromIreland committed Mar 29, 2025
commit 74d9b7d325b5ef6d51131ed11538ee098fdedbe6
1 change: 1 addition & 0 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4707,6 +4707,7 @@ def test_fromisoformat_fractions(self):

self.assertEqual(actual, expected)

@warnings_helper.ignore_warnings(category=DeprecationWarning)
def test_fromisoformat_time_examples(self):
examples = [
('0000', self.theclass(0, 0)),
Expand Down
2 changes: 1 addition & 1 deletion Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,7 @@ parse_isoformat_time(const char *dtstr, size_t dtlen, int *hour, int *minute,
if (tzinfo_pos + 2 < p_end && tzinfo_pos[2] != ':' && strlen(tzinfo_pos) > 2) {
PyErr_WarnEx(PyExc_DeprecationWarning,
"Support for partially expanded formats is deprecated in "
"accordance with ISO 8601:2 and will be removed in 3.15", 1);
"accordance with ISO 8601:2 and will be removed in 3.15", 2);
}

rv = parse_hh_mm_ss_ff(tzinfo_pos, p_end, &tzhour, &tzminute, &tzsecond,
Expand Down