Skip to content

gh-88473: Implement fast path in date.today() for date types #130980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pganssle merged 8 commits into from
Sep 16, 2025
Merged

gh-88473: Implement fast path in date.today() for date types #130980

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
557a060
Implement fast path
StanFromIreland Mar 8, 2025
0ecf2d4
Fix docs
StanFromIreland Mar 8, 2025
1fa3270
remove unnecessary parentheses in news
StanFromIreland Mar 8, 2025
46d83e3
Benedikts suggestions
StanFromIreland Mar 8, 2025
cf5c7c8
Slimming as per Benedikt
StanFromIreland Mar 12, 2025
372a764
Benedikt's final nits ;-)
StanFromIreland Mar 12, 2025
3bfd3ff
Merge branch 'refs/heads/main' into date_speedup
StanFromIreland Sep 15, 2025
38926d8
Conflict fixup
StanFromIreland Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Slimming as per Benedikt
  • Loading branch information
@StanFromIreland
StanFromIreland committed Mar 12, 2025
commit cf5c7c87e1fea4e9a74845467afd8cf208a73f12
25 changes: 10 additions & 15 deletions Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3274,22 +3274,17 @@ date_today(PyObject *cls, PyObject *Py_UNUSED(dummy))
tm.tm_mday,
(PyTypeObject*)cls);
Comment thread
StanFromIreland marked this conversation as resolved.
Outdated
}
else {
PyObject *time;
PyObject *result;
time = time_time();
if (time == NULL) {
return NULL;
}

/* Note well: today() is a class method, so this may not call
* date.fromtimestamp. For example, it may call
* datetime.fromtimestamp.
*/
result = PyObject_CallMethodOneArg(cls, &_Py_ID(fromtimestamp), time);
Py_DECREF(time);
return result;
PyObject *time = time_time();
Comment thread
StanFromIreland marked this conversation as resolved.
if (time == NULL) {
return NULL;
}

/* Note well: since today() is a class method, it may not call
* date.fromtimestamp, e.g., it may call datetime.fromtimestamp.
*/
PyObject *result = PyObject_CallMethodOneArg(cls, &_Py_ID(fromtimestamp), time);
Py_DECREF(time);
return result;
}

/*[clinic input]
Expand Down