Skip to content

gh-130821: Add type information to wrong type error messages #130835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 17 commits into from
Aug 14, 2025
Merged

gh-130821: Add type information to wrong type error messages #130835

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a513ee8
Add type information to wrong type error messages
donbarbos Mar 4, 2025
4d792e4
Use %T to format type names
donbarbos Mar 5, 2025
d976676
Fix error message for methods return type
donbarbos Apr 28, 2025
d811b4c
Revert "Fix error message for methods return type"
donbarbos Apr 28, 2025
70d57c2
Use new message template
donbarbos Apr 28, 2025
b6f75e4
Merge branch 'main' into issue-130821
donbarbos Apr 28, 2025
390f941
Improve message and fix test
donbarbos Apr 28, 2025
d2e54e6
Fix more methods
donbarbos Apr 28, 2025
0ac8a1c
Escape parentheses in regex pattern to fix test match
donbarbos Apr 28, 2025
59bca2d
Fix message for coroutine test
donbarbos Apr 28, 2025
51a6c79
Add News entry
donbarbos Apr 28, 2025
699b112
Update message template
donbarbos Apr 28, 2025
06606e4
Merge branch 'main' into issue-130821
donbarbos May 6, 2025
8c142f3
Merge branch 'main' into issue-130821
serhiy-storchaka Jul 6, 2025
97cf25c
Apply suggestions
donbarbos Aug 13, 2025
22baff6
Use %T
donbarbos Aug 13, 2025
29afd3c
Update typeobject.c
donbarbos Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Escape parentheses in regex pattern to fix test match
  • Loading branch information
@donbarbos
donbarbos committed Apr 28, 2025
commit 0ac8a1c132a1d9e822ef1749746b8341f84282ec
2 changes: 1 addition & 1 deletion Lib/test/test_type_annotations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def check_annotations(self, f):
print(f.__annotations__)

f.__annotate__ = lambda x: 42
with self.assertRaisesRegex(TypeError, r"__annotate__() must return type dict of type 'int'"):
with self.assertRaisesRegex(TypeError, r"__annotate__\(\) must return type dict of type 'int'"):
print(f.__annotations__)

f.__annotate__ = lambda x: {"x": x}
Expand Down