Skip to content

gh-130804: Fix support of typing unicode chars in pyrepl #130805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 7 commits into from
Mar 10, 2025
Merged

gh-130804: Fix support of typing unicode chars in pyrepl #130805

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d674cf
Fix support of typing unicode chars in pyrepl
sergey-miryanov Mar 3, 2025
c1f3aa8
Make mypy happy
sergey-miryanov Mar 3, 2025
ef0d0ee
Add assert to check if passed char is str
sergey-miryanov Mar 3, 2025
497a0bb
Merge branch 'main' into gh-130804-pyrepl-unicode-chars
sergey-miryanov Mar 4, 2025
bfa2e4e
Update Lib/_pyrepl/base_eventqueue.py
sergey-miryanov Mar 10, 2025
c667049
Merge branch 'main' into gh-130804-pyrepl-unicode-chars
sergey-miryanov Mar 10, 2025
7cc16ea
Add NEWS entry
pablogsal Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add assert to check if passed char is str
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed Mar 3, 2025
commit ef0d0ee2a98822a1b6bc34158242b8e1dbff0421
1 change: 1 addition & 0 deletions Lib/_pyrepl/base_eventqueue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def push(self, char: int | bytes | str) -> None:
"""
ord_char = char if isinstance(char, int) else ord(char)
if ord_char > 255:
assert isinstance(char, str)
char = bytes(char.encode(self.encoding))
Comment thread
sergey-miryanov marked this conversation as resolved.
Outdated
self.buf.extend(char)
else:
Expand Down