Skip to content

gh-126835: Move constant tuple folding to CFG #130769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 25 commits into from
Mar 19, 2025
Merged

gh-126835: Move constant tuple folding to CFG #130769

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
389f99f
remove tuple folding from ast_opt.c
WolframAlph Mar 2, 2025
c1e4f23
preserve constant tuple warnings
WolframAlph Mar 2, 2025
7ffac41
implement constant intrinsic list to tuple folding
WolframAlph Mar 2, 2025
4eae423
adjust tests
WolframAlph Mar 2, 2025
3691e74
add peepholer tests
WolframAlph Mar 2, 2025
ed312ad
add constant null check
WolframAlph Mar 2, 2025
3e41b41
address review
WolframAlph Mar 3, 2025
f150c15
update comment
WolframAlph Mar 3, 2025
4331a08
fold in codegen instead of cfg
WolframAlph Mar 3, 2025
70c4388
update const tuple creation
WolframAlph Mar 5, 2025
4a44c02
Revert "update const tuple creation"
WolframAlph Mar 5, 2025
d0cd2a5
Revert "fold in codegen instead of cfg"
WolframAlph Mar 5, 2025
e4d9164
remove comment
WolframAlph Mar 5, 2025
75a2762
replace typeparam tests from test_ast in test_compile
WolframAlph Mar 5, 2025
f0429c8
process 2 instructions per iteration
WolframAlph Mar 6, 2025
939fbee
make 2 passes to avoid unnecessary allocations
WolframAlph Mar 6, 2025
57e6f07
add more tests
WolframAlph Mar 6, 2025
4ae59f8
improve styling
WolframAlph Mar 6, 2025
bffc456
address reivew
WolframAlph Mar 7, 2025
e8e70e0
get rid of label
WolframAlph Mar 7, 2025
a7dbe98
inline noping out
WolframAlph Mar 7, 2025
836c0ee
add more tests
WolframAlph Mar 7, 2025
72a3e65
resolve conflicts
WolframAlph Mar 18, 2025
967a18e
use new nop_out
WolframAlph Mar 18, 2025
4b11cf8
Merge branch 'main' into tuple-fold-cfg
iritkatriel Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add more tests
  • Loading branch information
@WolframAlph
WolframAlph committed Mar 18, 2025
commit 836c0ee500d58c1e6509320756a66f62690b03a5
13 changes: 13 additions & 0 deletions Lib/test/test_peepholer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,6 +1441,19 @@ def test_fold_constant_intrinsic_list_to_tuple(self):
]
self.cfg_optimization_test(before, after, consts=[], expected_consts=[(1, 2, 3)])

# no sequence start
same = [
('LOAD_SMALL_INT', 1, 0),
('LIST_APPEND', 1, 0),
('LOAD_SMALL_INT', 2, 0),
('LIST_APPEND', 1, 0),
('LOAD_SMALL_INT', 3, 0),
('LIST_APPEND', 1, 0),
('CALL_INTRINSIC_1', INTRINSIC_LIST_TO_TUPLE, 0),
('RETURN_VALUE', None, 0)
]
self.cfg_optimization_test(same, same, consts=[])

def test_optimize_if_const_list(self):
before = [
('NOP', None, 0),
Expand Down