Skip to content

gh-130524 Create WinGetpassTest class for improved coverage #130529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtranq wants to merge 11 commits into from
Closed

gh-130524 Create WinGetpassTest class for improved coverage #130529

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1e1514f
Create WinGetpassTest class
jtranq Feb 25, 2025
850a357
Fix linter error re: Redefinition of mscvrt
jtranq Feb 25, 2025
15cb9a8
Add proper Windows-specific unittest decorator
jtranq Feb 25, 2025
023c77d
Try alternate Windows-specific test decorator
jtranq Feb 25, 2025
b2e44fc
Fixing name-error
jtranq Feb 25, 2025
730f8bc
Apply suggestions from code review
jtranq Feb 25, 2025
e4dcd93
picnixz suggestions
jtranq Feb 25, 2025
2bf440c
Update Lib/test/test_getpass.py
jtranq Feb 25, 2025
ca46d3d
Maintain context manager syntax
jtranq Feb 25, 2025
778e839
Apply suggestions from code review
jtranq Feb 25, 2025
4e287cd
Apply suggestions from code review
jtranq Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Maintain context manager syntax
  • Loading branch information
@jtranq
jtranq committed Feb 25, 2025
commit ca46d3d2d53551373cf8da48b02d7c89eae95456
14 changes: 4 additions & 10 deletions Lib/test/test_getpass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
try:
import msvcrt
except ImportError:
mscvrt = None
msvcrt = None

@mock.patch('os.environ')
class GetpassGetuserTest(unittest.TestCase):
Comment thread
jtranq marked this conversation as resolved.
Expand Down Expand Up @@ -185,16 +185,11 @@ def test_uses_msvcrt_directly(self):
mock_stream.flush.assert_called()

def test_handles_backspace(self):
with (
mock.patch('msvcrt.getch') as getch,
mock.patch('msvcrt.putch') as putch,
):
with mock.patch('msvcrt.getch') as getch, \
mock.patch('msvcrt.putch') as putch:
getch.side_effect = [b'a', b'b', b'\b', b'c', b'\r']
result = getpass.win_getpass()
self.assertEqual(result, 'ac')
# Verify putch was called to handle the backspace (erase character)
# The exact sequence depends on the implementation, but should include
# calls to handle the backspace character
putch.assert_any_call(b'\b')

def test_handles_ctrl_c(self):
Expand All @@ -214,8 +209,7 @@ def test_flushes_stream_after_input(self):

def test_falls_back_to_fallback_if_msvcrt_raises(self):
with mock.patch('msvcrt.getch') as getch, \
mock.patch('getpass.fallback_getpass') as fallback:
# Make getch raise an exception to trigger the fallback
mock.patch('getpass.fallback_getpass') as fallback:
getch.side_effect = RuntimeError("Simulated msvcrt failure")
mock_stream = mock.Mock(spec=StringIO)
getpass.win_getpass(stream=mock_stream)
Expand Down